Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove benchmark and split options from evauation #1741

Closed
2 tasks done
Fleyderer opened this issue Nov 15, 2024 · 2 comments
Closed
2 tasks done

Remove benchmark and split options from evauation #1741

Fleyderer opened this issue Nov 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Fleyderer
Copy link
Contributor

Search before asking

  • I have searched the Yolov8 Tracking issues and found no similar enhancement requests.

Description

How it works now

We have --benchmark and --split options, which should be passed together with the --source parameter, where we already have .../<benchmark>/<split> inside the path.

How it will work:

benchmark = Path(opt.source).name
split = Path(opt.source).parent

And of cource this info should be reflected in log.

I have tried to avoid this change, but I am tired of this unexpected behaviour when I pass .../MOT17/test as the source and somehow script is yelling at me that he can't find file from test or something else 😃

I decided to know your opinion before changing, these options are used only in val.py file

Use case

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@Fleyderer Fleyderer added the enhancement New feature or request label Nov 15, 2024
@mikel-brostrom
Copy link
Owner

I agree. It is confusing. Let's only keep source and extract the benchmark from the source path itself?

@mikel-brostrom
Copy link
Owner

this got fixed here: #1746

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants