Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduledReporter enhancements #39

Open
tolbertam opened this issue Dec 28, 2016 · 2 comments
Open

ScheduledReporter enhancements #39

tolbertam opened this issue Dec 28, 2016 · 2 comments
Assignees
Milestone

Comments

@tolbertam
Copy link
Collaborator

After revisiting ScheduledReporter and its implementations for a bit, have a few ideas for enhancements:

  1. Add callback / promise support to report() that completes when all reporting duties are completed. This will allow the user to detect when reporting completes (so perhaps they can schedule another report if they want to control it manually) or fails.
  2. Using enhancement 1, only allow one in flight report at a time. While it seems unlikely, if there are concurrent reports happening at a time, you could have interlaced data.
  3. Allow CsvReporter and GraphiteReporter to be used without requiring user to call start. This would allow the user to manually control when data is reported with these reporters.
  4. Support duration and rate time unit configurations like dropwizard metrics does so user can request the time unit displayed in their reports.
@mikejihbe
Copy link
Owner

I think numbers 3 and 4 would require a version bump, which I'm fine with. These seem like reasonable additions to me.

@mikejihbe
Copy link
Owner

Can you shoot me an email at mike at mustwin .com, I'd like to discuss something else with you too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants