Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jsonwebtoken to v8.3.0 to v9.x.x #302

Closed
marcb opened this issue Nov 23, 2023 · 2 comments
Closed

Bump jsonwebtoken to v8.3.0 to v9.x.x #302

marcb opened this issue Nov 23, 2023 · 2 comments

Comments

@marcb
Copy link

marcb commented Nov 23, 2023

Summary

Building for aarch64-pc-windows-msvc breaks due to ring v0.16.0 via jsonwebtoekn v8.3.0. Ring fix starts with v9.0.0

cargo tree -p ring -i
ring v0.16.20
└── jsonwebtoken v8.3.0
    └── jwt-cli v6.0.0 (/Users/marc/src/oss/jwt-cli)

Steps to reproduce

On Windows 11 on AARCH64 machine with rustup 1.26.0 (5af9b9484 2023-04-05), rustc 1.74.0 (79e9716c9 2023-11-13), cargo 1.74.0 (ecb9851af 2023-10-18). Installing via cargo install jwt-cli - ring has build failures. See ring issue briansmith/ring#1167 for background.

Expected behavior

With a jsonwebtoken version >= 9.0.0 it should build and install.

@mike-engel
Copy link
Owner

PR: #296. I haven't had time to do the upgrade yet. If anyone would like to take a stab at it, I'm happy to review PRs 😄

@mike-engel
Copy link
Owner

Done as of #311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants