Allow wss connections #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ws:// is only allowed if the webpage is served over HTTP. If serving the webpage over HTTPS then a wss:// URL must be sent to the browser. To do this we attempts to load the ws:// URL first and if the browser throws a DOMexception then we "catch" it and attempts to setup a wss:// URL instead.
| Turbo.connectStreamSource(new WebSocket(`ws://${location.host}/turbo-stream`)); | ||
| } catch(error) { | ||
| Turbo.connectStreamSource(new WebSocket(`wss://${location.host}/turbo-stream`)); | ||
| } |
There was a problem hiding this comment.
It would be better to get the correct scheme from the page, I should have done that and forgot.
There was a problem hiding this comment.
Do you mean the request.scheme variable in Flask? The problem with that is that the client may be connecting with HTTPS to an Nginx proxy frontend and Nginx then speaks HTTP to the Flask backend, giving incorrect info about what scheme the browser is actually using.
There was a problem hiding this comment.
That problem has a solution, the ProxyFix middleware addresses that. But if you prefer, you can look at the scheme in the browser side.
Your solution is not good because it prefers ws:// over wss://.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ws:// is only allowed if the webpage is served over HTTP. If serving the webpage over HTTPS then a wss:// URL must be sent to the browser.
To do this we attempt to load the ws:// URL first and if the browser throws a DOMexception then we "catch" it and attempts to setup a wss:// URL instead.