render md-select-header outside of md-content #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New test fails on |
Try to fix issue with ember-beta... not sure what it could be...
|
Great stuff. 👍 |
miguelcobain
pushed a commit
that referenced
this pull request
Nov 27, 2018
…1027) #941 removed the wrapping `md-content` tag in `paper-select` with `searchEnabled=true` which causes problems (#1025) in the `calculatePosition` method of `paper-select-menu` when the `paper-select` is clicked without any `options` available. This PR adds a `md-content` wrapper around the `searchMessageComponent` in `paper-select`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why it was done this way to begin with, but rendering
md-select-headeroutside ofmd-contentmake it sticky to the top which is a huge usability improvement.Closes #938