Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
ember-wormhole
with built in-in-element
.This mirrors the direction
ember-basic-dropdown
is going https://github.com/cibernox/ember-basic-dropdown/releases/tag/v1.0.0-beta.0Fixes usage of
ember-basic-dropdown
1.0.0 but won't work for ember < 2.10.What versions do we support?
In my opinion if
ember-basic-dropdown
andember-power-select
are dropping support for Glimmer 1 apps, we should too in v1.0.0