-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add super calls inside paper-input lifecycle hooks. #506
Add super calls inside paper-input lifecycle hooks. #506
Conversation
* ensures hooks higher up in mixinx will fire properly
@miguelcobain I was also experiencing this. This should fix errors like I haven't tested his fix, but I suspect this fixed the issue. EDIT: I tested this and sure enough that was the issue. |
There is a form related error that is failing. Mind checking that? |
@miguelcobain will do later today |
* keeps super call on willDestroyElement fixing bug * assumes the super call on didRender was causing issues on non-default builds.
the only thing I can think of is the super call inside the |
@jordpo @miguelcobain The |
the default scenario fails if we update the assert.expect to 3. I wonder if we can just take the assert.expect out? |
@jordpo I really have to wonder why the default scenario fails at 3. I can't think out why it would be anything but 3. If we remove the Maybe @miguelcobain can rectify why the default build returns anything but 3 assertions? |
this was causing an error when we were using the
paper-form
input and dynamically adding/removing its child components in the form based on the current form data.