Move paper-wormhole div out of head tag.
#311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can definitely cause some really strange bugs (which is how I found this bug in the first place), so I think this warrants a bugfix release. |
|
I don't know how this ended up like that this far. |
The `paper-wormhole` div is currently insterted into the `<head>` of the index.html page, which causes DOM parsing problems for browsers. The `div` element cannot appear in the `<head>`, and causes Chrome to move the `<body>` tag up to enclose the first `<div>`, breaking all subsequent `<head>` tags (favicons, etc.) This change places the tag as the first element in the `<body>` tag, which should be equivalent for Paper.
blimmer
force-pushed
the
bug/div-in-head-tag
branch
from
498e524 to
72c98c0
Compare
|
Updated changelog and amended commit. |
|
Thanks! |
miguelcobain
added a commit
that referenced
this pull request
Mar 15, 2016
Move `paper-wormhole` div out of head tag.
|
Published 0.2.12 |
|
Thanks for handling this so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
paper-wormholediv is currently insterted into the<head>of the index.html page,which causes DOM parsing problems for browsers. The
divelement cannot appear in the<head>, and causes Chrome to move the<body>tag up to enclose the first<div>, breakingall subsequent
<head>tags (favicons meta, etc.)This change places the tag as the first element in the
<body>tag, which shouldbe equivalent for Paper.