-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidenav + layout fixes to ember-paper #138
Sidenav + layout fixes to ember-paper #138
Conversation
Animations should now work ( and are generic implementation against angular's structure of defining animations in the css (that is compatible with |
}), | ||
|
||
lockedOpenDefinition: Ember.computed.alias('locked-oppen'), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
locked-oppen , should be open, and this is not used it seems.
@miguelcobain Refactored some code style to correct and polished this one, it should be good and contains latest scss for backdorp and also animation now works. This contains the important animation-mixin that is used to animate components and conforms to the ng-enter ng-enter-active style approach to animations (so we can use the CSS directly from angular ) Could you take a look at this one when you have fime ? |
533294d
to
bc31c59
Compare
…ents may use such as menu sidebar in this PR.)
@miguelcobain This PR now uses ember-css-transitions. Demo updated also to see that backdrop works: http://jensb.home.pkj.no/ember-layout/index.html |
…oes no longer depend on adopted-ember-addons#138.
@peec great work, as usual! I believe the introduction of ember-css-transitions is a step forward. We can focus on possible animation improvements separately on that project. Sorry for the delay in reviewing this, but my time is a bit limited at the moment (I'm hoping this will change soon). |
Fixes a missing dependency added by adopted-ember-addons#138.
…oes no longer depend on adopted-ember-addons#138.
…oes no longer depend on adopted-ember-addons#138.
…oes no longer depend on adopted-ember-addons#138.
…oes no longer depend on adopted-ember-addons#138.
Demo of this PR: http://jensb.home.pkj.no/ember-layout/index.html
This PR is about:
locked-open
which supports all given constants (in constants service like in agular-material):sm, gt-sm, md, gt-md, lg, gt-lg
etc. This means you can have many components with flexible lock-open on the menu.window.matchMedia
is included as a bower dependency. ( Which is needed to check for locked-open attributes ).Some of this are from ember-material-design, such as making menu animating ( see
app/styles/paper-sidenav.scss
)Edit: Updated to latest 0.2.7