Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module-unification bluerpint #1064

Merged
merged 4 commits into from
Feb 22, 2019
Merged

module-unification bluerpint #1064

merged 4 commits into from
Feb 22, 2019

Conversation

betocantu93
Copy link
Contributor

This is a clean PR for module-unification blueprint compatibility

continues #1054

@betocantu93 betocantu93 mentioned this pull request Feb 15, 2019
Closed
@ppcano
Copy link

ppcano commented Feb 15, 2019

Regarding the CI I can turn off the linter in that file or add module to globals?

@betocantu93

Excluding the file at https://github.com/miguelcobain/ember-paper/blob/master/.eslintrc.js#L24 or move the function to the index.js should work and CI will likely success 🚀

@ppcano
Copy link

ppcano commented Feb 22, 2019

@miguelcobain Any blocker to merge this PR?

@miguelcobain miguelcobain merged commit 395ec7b into adopted-ember-addons:master Feb 22, 2019
@miguelcobain
Copy link
Collaborator

Thanks guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@betocantu93 @ppcano @miguelcobain