Fix paper select click-catcher to call dropdown.actions.close on click #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a project where I'm using the latest beta of ember-paper, I noticed my paper selects were not closing when clicking outside the menu options area. Seems the paper-backdrop does not have the onClick value set. Making it call the dropdown.actions.close fixed the issue as per this PR.
Not 100% sure if I'm using the component somehow wrong as in the demo it seems to work. In any case, if this fix is relevant do merge this in - if not, ignore! Thanks for all the work on this. :)