Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing md-content when displaying searchMessage in paper-select #1027

Merged
merged 1 commit into from
Nov 27, 2018
Merged

fix missing md-content when displaying searchMessage in paper-select #1027

merged 1 commit into from
Nov 27, 2018

Conversation

wahhaj
Copy link
Contributor

@wahhaj wahhaj commented Nov 26, 2018

#941 removed the wrapping md-content tag in paper-select with searchEnabled=true which causes problems (#1025) in the calculatePosition method of paper-select-menu when the paper-select is clicked without any options available.

This PR adds a md-content wrapper around the searchMessageComponent in paper-select.

@miguelcobain miguelcobain merged commit 00cf024 into adopted-ember-addons:master Nov 27, 2018
@miguelcobain miguelcobain mentioned this pull request Nov 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wahhaj @miguelcobain