Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist whitelist components #1021

Conversation

betocantu93
Copy link
Contributor

The past PR was corrupted, this is a clean PR.

whitelist/blacklist components using ember-bootstrap approach.

For whitelist, all the component dependencies will also be included.

@betocantu93 betocantu93 mentioned this pull request Nov 2, 2018
@miguelcobain
Copy link
Collaborator

@betocantu93 an interesting addition would be to not include

<link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons">

if paper icon is blacklisted/not white listed.

@betocantu93
Copy link
Contributor Author

@miguelcobain yep, that's a good idea!

@miguelcobain miguelcobain force-pushed the blacklist-whitelist-components branch from f71b537 to 639fa7b Compare November 26, 2018 17:00
@miguelcobain miguelcobain merged commit 8134472 into adopted-ember-addons:master Nov 26, 2018
miguelcobain pushed a commit that referenced this pull request Nov 30, 2018
This is a follow up of the #1021 PR, this will only import the css of the whitelist-blacklist, as a reminder, you can only use one at the same time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants