IE11: Object doesn't support property or method 'forEach'

[panthony]

I have this issue on IE 11 in paper-dialog-inner because of the following line:

    let imageElements = this.element.querySelectorAll('img');
    // ...
    imageElements.forEach((image) => {
      image.addEventListener('load', this._checkContentOverflowOnLoad);
    });

As IE11 does not support .forEach on querySelectorAll result (see here).

The fix could be either to transform imageElements as an array [...document.querySelectorAll()] or add a small polyfill to add forEach on NodeList as suggested on developer.mozilla.org

[m3l1x]

+1 running into exactly the same issue on Firefox older than 50

[panthony]

@m3l1x I added the suggered polyfill to fix the issue:

// missing forEach on NodeList for IE11
if (window.NodeList && !NodeList.prototype.forEach) {
  NodeList.prototype.forEach = Array.prototype.forEach;
}

[miguelcobain]

@panthony @m3l1x I created ember-cli-polyfill-importer and used it to import our polyfills, including nodelist foreach that this issue is about.

Could you please test your apps with ember-paper master to confirm that the polyfill is being added?

Please make sure that IE or FF < 50 (or any other version that doesn't have nodelist forEach) are included in your config/targets.js file.

[panthony]

@miguelcobain (Un)fortunately I'm not equipped to test something on IE11.

What about this issue? Shall I close it?

I'm afraid others might be surprised by this issue too because it means that OOTB ember-paper is not compatible with IE11, unless you add this polyfill addon.

[m3l1x]

@miguelcobain @panthony I gonna test it on monday and report.

[miguelcobain]

It is working for me on IE11!

Please reopen if issue persists.

[kumaresan-subramani]

@m3l1x I added the suggered polyfill to fix the issue:

// missing forEach on NodeList for IE11
if (window.NodeList && !NodeList.prototype.forEach) {
  NodeList.prototype.forEach = Array.prototype.forEach;
}

@m3l1x , can you share polyfills link?