fix computed property overrides deprecation. fixes #1146

adopted-ember-addons · May 9, 2020 · 52dd556 · 52dd556
1 parent 48f7ad5
commit 52dd556
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 11 deletions.
diff --git a/addon/components/paper-progress-linear.js b/addon/components/paper-progress-linear.js
@@ -35,18 +35,27 @@ export default Component.extend(ColorMixin, {
 
   constants: service(),
 
-  mode: computed('value', function() {
-    let value = this.get('value');
-    let bufferValue = this.get('bufferValue');
+  mode: computed('value', {
+    get() {
+      if (this._mode !== undefined) {
+        return this._mode;
+      }
 
-    if (isPresent(value)) {
-      if (isPresent(bufferValue)) {
-        return MODE_BUFFER;
+      let value = this.get('value');
+      let bufferValue = this.get('bufferValue');
+
+      if (isPresent(value)) {
+        if (isPresent(bufferValue)) {
+          return MODE_BUFFER;
+        } else {
+          return MODE_DETERMINATE;
+        }
       } else {
-        return MODE_DETERMINATE;
+        return MODE_INDETERMINATE;
       }
-    } else {
-      return MODE_INDETERMINATE;
+    },
+    set(key, value) {
+      return this._mode = value;
     }
   }),
 

diff --git a/addon/mixins/child-mixin.js b/addon/mixins/child-mixin.js
@@ -16,8 +16,18 @@ export default Mixin.create({
   parentClass: ParentMixin,
 
   // this will typically be overriden when yielding a contextual component
-  parentComponent: computed(function() {
-    return this.nearestOfType(this.get('parentClass'));
+  parentComponent: computed({
+    get() {
+      if (this._parentComponent !== undefined) {
+        return this._parentComponent;
+      }
+
+      return this.nearestOfType(this.get('parentClass'));
+    },
+
+    set(key, value) {
+      return this._parentComponent = value;
+    }
   }),
 
   init() {