Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember 2.0 Support #86

Closed
thehydroimpulse opened this issue Jul 10, 2015 · 9 comments
Closed

Ember 2.0 Support #86

thehydroimpulse opened this issue Jul 10, 2015 · 9 comments

Comments

@thehydroimpulse
Copy link

Testing on canary results in the following error being reported:

Uncaught TypeError: Ember.default.beforeObserver is not a function
(anonymous function)    @   ember-selectize.js:298
mod.state   @   loader.js:141
tryFinally  @   loader.js:21
requireModule   @   loader.js:139
requireFrom @   loader.js:112
reify   @   loader.js:97
mod.state   @   loader.js:140
tryFinally  @   loader.js:21
requireModule   @   loader.js:139
Ember.DefaultResolver.extend._extractDefaultExport  @   ember-resolver.js:367
resolveOther    @   ember-resolver.js:109

http://emberjs.com/deprecations/v1.x/#toc_beforeobserver

I can send a patch if you'd like.

@miguelcobain
Copy link
Owner

I would love a patch.
I confess I didn't understand how the code you linked to can replace beforeObservers, but I'm sure that's just me. 😧

@marcemira
Copy link
Contributor

👍 Please fix this :3

@miguelcobain
Copy link
Owner

Ember 1.13.4 introduced a bug which basically removed beforeObservers instead of deprecating them. That makes ember-cli-selectize to fail in Ember 1.13.4.

Waiting for this fix: emberjs/ember.js#11744

@rwjblue
Copy link

rwjblue commented Jul 15, 2015

I just merged that PR fixing the deprecateFunc behavior, and pulled into release branch. Folks can use bower install --save ember#release until 1.13.5 is released (which should be a few days).

@miguelcobain
Copy link
Owner

ember-try is now passing, thanks!

------ RESULTS ------

default: PASS
ember-release: PASS
ember-beta: PASS
ember-canary: PASS

Is it supposed to be passing in ember canary/beta, since I'm using beforeObserver?
I thought Ember 2.0 would remove all deprecated functionality.

@grapho
Copy link
Contributor

grapho commented Jul 16, 2015

Where are we with this issue? Do we still need a solution to replace the (2) uses of beforeObserver? I am working on my local version to see what i can do to fix, and will PR if no one posts a fix before me.

@miguelcobain
Copy link
Owner

Yes, we still need to get rid of beforeObservers.
A PR for that would be great! I'm a bit short on time ATM.

@grapho
Copy link
Contributor

grapho commented Jul 16, 2015

well I will work on it today. hopefully i can come with a solution soon.. because the alternative is to rollback and wait.. ugk

@miguelcobain
Copy link
Owner

Fixed on 1fbfaa3

Latest version should be Ember 2.0 compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants