diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 92218372..4ffe48a3 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -43,16 +43,16 @@ jobs: - uses: actions/checkout@v3 with: fetch-depth: 0 # for commit linting - # Hiding tsconfig.json to workaround - # https://github.com/conventional-changelog/commitlint/issues/3256 - - run: mv tsconfig.json tsconfig.json.nope - - uses: wagoid/commitlint-github-action@v5 - - run: mv tsconfig.json.nope tsconfig.json - uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} - run: npm --global install npm@latest - run: npm ci + # Hiding tsconfig.json to workaround + # https://github.com/conventional-changelog/commitlint/issues/3256 + - run: mv tsconfig.json tsconfig.json.nope + - uses: wagoid/commitlint-github-action@v5 + - run: mv tsconfig.json.nope tsconfig.json - run: npm test get-supported-node-versions: runs-on: ubuntu-latest diff --git a/commitlint.config.js b/commitlint.config.js index 4fedde6d..1c7ec83e 100644 --- a/commitlint.config.js +++ b/commitlint.config.js @@ -1 +1 @@ -module.exports = { extends: ['@commitlint/config-conventional'] } +module.exports = { extends: ['standard'] } diff --git a/package-lock.json b/package-lock.json index 5d436f95..a3ecc869 100644 --- a/package-lock.json +++ b/package-lock.json @@ -29,6 +29,7 @@ "@typescript-eslint/eslint-plugin": "5.62.0", "@ungap/structured-clone": "1.2.0", "ava": "5.3.1", + "commitlint-config-standard": "github:standard/commitlint-config-standard", "editorconfig-checker": "5.1.1", "eslint": "8.46.0", "eslint-plugin-import": "2.28.0", @@ -2813,6 +2814,12 @@ "integrity": "sha512-72fSenhMw2HZMTVHeCA9KCmpEIbzWiQsjN+BHcBbS9vr1mtt+vJjPdksIBNUmKAW8TFUDPJK5SUU3QhE9NEXDw==", "dev": true }, + "node_modules/commitlint-config-standard": { + "version": "0.0.0", + "resolved": "git+ssh://git@github.com/standard/commitlint-config-standard.git#dfd078f5061e0a58d406fc47526368f996043cae", + "dev": true, + "license": "MIT" + }, "node_modules/common-path-prefix": { "version": "3.0.0", "resolved": "https://registry.npmjs.org/common-path-prefix/-/common-path-prefix-3.0.0.tgz", diff --git a/package.json b/package.json index 7a7cc301..defc24ba 100644 --- a/package.json +++ b/package.json @@ -81,6 +81,7 @@ "@typescript-eslint/eslint-plugin": "5.62.0", "@ungap/structured-clone": "1.2.0", "ava": "5.3.1", + "commitlint-config-standard": "github:standard/commitlint-config-standard", "editorconfig-checker": "5.1.1", "eslint": "8.46.0", "eslint-plugin-import": "2.28.0", diff --git a/src/index.test.ts b/src/index.test.ts index 5d2ae27c..65b1ac96 100644 --- a/src/index.test.ts +++ b/src/index.test.ts @@ -314,6 +314,7 @@ test('Dependencies range types', async (t) => { `Peer dependency \`@typescript-eslint/eslint-plugin: ${typescriptEslintPluginValue}\` is a single \`^\` range.` ) for (const [name, spec] of Object.entries(ourDevDeps)) { + if (spec.startsWith('github:')) continue const range = name.startsWith(`${typescriptEslintBottom}/`) ? extractVersionSpec(spec) : spec t.true(isPinnedRange(range), `Dev dependency \`${name}: ${spec}\` is pinned`) }