You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Users of the alpha version of the browser extension are getting an error saying
'Subtitle styling is not available for the selected language.' (in a HTML alert) when trying to click the MPV subs button. The subs in MPV do not get styled, and none of the functionality of migaku MPV works. I have looked at the source code, and am pretty sure I have found the issue.
Start a video in mpv, press b to launch the browser window. Now, open the console and try to log lang and parser. You should get 'Disabled' and null respectively. Then, select a language such as japanese in the extension, press parse, and repeat. Now, you should get 'ja' and 'ja'. Users who are experiencing this issue instead get null. Looking at the source code, lang being null means parser will never be set, so it too will be null forever.
This issue only happens on the alpha version of the extension because the css selector for lang_elem is harcoded, and the layout of the extension has been changed. To fix this, this function needs to be updated.
The text was updated successfully, but these errors were encountered:
Users of the alpha version of the browser extension are getting an error saying
'Subtitle styling is not available for the selected language.' (in a HTML alert) when trying to click the MPV subs button. The subs in MPV do not get styled, and none of the functionality of migaku MPV works. I have looked at the source code, and am pretty sure I have found the issue.
Start a video in mpv, press b to launch the browser window. Now, open the console and try to log
lang
andparser
. You should get'Disabled'
andnull
respectively. Then, select a language such as japanese in the extension, press parse, and repeat. Now, you should get'ja'
and'ja'
. Users who are experiencing this issue instead getnull
. Looking at the source code,lang
beingnull
meansparser
will never be set, so it too will benull
forever.lang
should be set ingrabLangSettings
:This issue only happens on the alpha version of the extension because the css selector for
lang_elem
is harcoded, and the layout of the extension has been changed. To fix this, this function needs to be updated.The text was updated successfully, but these errors were encountered: