Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option toggle "Show informational notifications" defunct #1541

Closed
4 tasks done
xbyte99 opened this issue Apr 5, 2023 · 10 comments
Closed
4 tasks done

Option toggle "Show informational notifications" defunct #1541

xbyte99 opened this issue Apr 5, 2023 · 10 comments

Comments

@xbyte99
Copy link

xbyte99 commented Apr 5, 2023

I have a lot of issues to go through, so in order to make it easier for me to help you, I ask that you please try these things first

Operating System

Windows 10

Steps to reproduce

Settings > Prompts and dialogs > Show informational notifications > click on the enable/disable slider button.

Expected behavior

As it is not a grayed out/disabled button it is expected to react to clicks, thus enabling or disabling informational notifications

There's no further explanation to this option but I would assume (and hope), that the "Export is done" dialog window would not be shown after a successful export. In my case, as I'm often cutting dozens of videos after another, it's kind of annoying having to click the "close" button of this dialog when drag&drop a new file to the main window.

Actual behavior

There's no change, no reaction to a click, it stays enabled.

Share log

No response

@mifi
Copy link
Owner

mifi commented Apr 5, 2023

right. that's a bug. thanks!

@mifi mifi closed this as completed in f62fe6d Apr 5, 2023
@VL4DST3R
Copy link

Came here to report the same issue, using the latest 3.54.0 i can't seem to be able to change it, the switch again not working like OP said. Please tell me we're not stuck with that useless "export is done" blocking popup at the end?

@mifi
Copy link
Owner

mifi commented Jul 27, 2023

you're stuck with it until the next version comes out. or you could go here and find the latest build: https://github.com/mifi/lossless-cut/actions/runs/5679153798

@VL4DST3R
Copy link

VL4DST3R commented Jul 27, 2023

I was literally checking the commit version and couldn't figure out why it was newer than latest build XD Thanks.

Edit: Nevermind, the version you have linked doesn't seem to run at all on my machine.

@VL4DST3R
Copy link

In the meantime shouldn't it be possible to set this to false via the config.json? I can't seem to find an entry that correlates with that checkbox.

@mifi
Copy link
Owner

mifi commented Jul 27, 2023

<Switch checked={!hideNotifications} onCheckedChange={(v) => setHideNotifications(v ? undefined : 'all')} />

@VL4DST3R
Copy link

VL4DST3R commented Jul 27, 2023

I'm talking within the config.json file under %AppData%, i have no "hideNotifications" entry or similar, and adding it manually makes no difference. Am i missing something?

@mifi
Copy link
Owner

mifi commented Jul 27, 2023

i don't understand, why do you need to add it in config.json? doesn't the toggle button work on the latest build?

@VL4DST3R
Copy link

VL4DST3R commented Jul 27, 2023

I couldn't install the 3.55.0 build- the version you linked me above. It would not open at all, spawning 3 processes with 0 activity. No errors in event viewer, no notifications, nothing. I eventually reverted to the "official" latest 3.54 and was trying to manually set that in the config.json to achieve the same result.

@mifi
Copy link
Owner

mifi commented Aug 21, 2023

yes there was an issue with the latest github actions artifact, should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants