Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment colour scheme generate results in poor contrast ratio #1199

Open
Tracked by #483
SignpostMarv opened this issue Jun 18, 2022 · 4 comments
Open
Tracked by #483

Segment colour scheme generate results in poor contrast ratio #1199

SignpostMarv opened this issue Jun 18, 2022 · 4 comments

Comments

@SignpostMarv
Copy link

Describe the bug
A clear and concise description of what the bug is.

To Reproduce

  1. Run LosslessCut 3.45.0
  2. Load a video
  3. Add enough segments that you start to get pastel-type colours, or high-lightness colours such as yellows etc.
  4. Observe that the the white timeline & playback indicators against these high-lightness colours are not easily visible due to the contrast ratio unless they are directly over the timecode/percentage indicator.

Expected behavior
Either:

  • dynamic timeline/playback indicators that switch between black/white depending on which is best for contrast
  • extend the translucent background of the timecode/percentage indicator across the entire width of the timeline scrubber.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
@SignpostMarv
Copy link
Author

p.s. I was tempted to add multiple highlight circles on the screenshot to prove a point, but left it with just the actual timeline indicator loosely circled so you're in the general vicinity but still have to look for it carefully.

@mifi
Copy link
Owner

mifi commented Jun 27, 2022

Gotcha. I never thought people would add 1000 segments on top of eachother but I guess it's also a use case 😅

I think what we need is css mix-blend-mode: difference or so..

@SignpostMarv
Copy link
Author

These particular ones are are consecutive, not overlapping? 🤔

@mifi
Copy link
Owner

mifi commented Jun 27, 2022

Ah i thought the overlapping caused the color to wash out into one pastel/grey like color. But yea it makes sense to make the cursor higher visibility anyhow

@mifi mifi mentioned this issue Aug 7, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants