Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Maker Bugs #75

Closed
omodia opened this issue Mar 1, 2023 · 7 comments
Closed

Theme Maker Bugs #75

omodia opened this issue Mar 1, 2023 · 7 comments

Comments

@omodia
Copy link

omodia commented Mar 1, 2023

Issue

1. --icon-color

  • 'Link' is linked to --font-color instead of --icon-color.
  • Some fonts are changing when using --icon-color. The fonts should be linked to --font-color.

2
--icon-color
2

@omodia
Copy link
Author

omodia commented Mar 1, 2023

2. --btn-color1 to --button-color1

  • Some button colors are not linked to it and are instead lined to --icon-color.

2
--button-color1
2

@omodia
Copy link
Author

omodia commented Mar 1, 2023

3. --font-color

  • Many fonts are not linked to it and are instead linked --icon-color.
  • Reader settings font colors are not being changed.
  • 'search' in list is not changed.
  • These are linked to --icon-color.

--font-color

@omodia
Copy link
Author

omodia commented Mar 1, 2023

4. --color-primary

  • It is not linked to anything.

5. --color-secondary

  • This should be linked to the list view's manga and chapter below and above lines too.

2
--color-secondary
2

@omodia
Copy link
Author

omodia commented Mar 1, 2023

  1. --divider-color
  • Collapsible vertical Main divider lines in the home page are not lined to it.

@mienaiyami
Copy link
Owner

I actually need to redo whole theme system as it wasnt in mind to make it customizable when i started

@omodia
Copy link
Author

omodia commented Mar 1, 2023

I actually need to redo whole theme system as it wasnt in mind to make it customizable when i started

Thank you. Looking forward to it.

@omodia
Copy link
Author

omodia commented Mar 1, 2023

Some suggestions / requests when redoing the theme system,

  • Full names without shortcuts. For example, btn-color to Button Colour, body-bg to Body Background, etc.
  • Clear names. For example, colour-primary, colour-secondary are not simple to understand.
  • Whereas Divider-Colour, Font-Colour are simple to understand and clear names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants