Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side effect of choosing themes anywhere (theme maker, reader settings) #230

Closed
zeoint opened this issue Aug 9, 2023 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@zeoint
Copy link

zeoint commented Aug 9, 2023

Type of installation

Portable (.zip)

Steps to reproduce

  1. Change a theme of background / font / anything from theme maker in settings.
  2. Even if the reset button is clicked or not, it does't change the outcome.
  3. Open any manga/epub.
  4. Open and close dev tools.
  5. The last used theme selector appears on screen.
  6. The changes made to the theme can also be seen.

  1. Open any manga and change custom color filter to any other color.
  2. Open and close dev tools.
  3. The same is repeated.

✔️ Expected Behavior

For that side effect to not occur.

❌ Actual Behavior

Side effect occurs.

@zeoint zeoint added the bug Something isn't working label Aug 9, 2023
@zeoint
Copy link
Author

zeoint commented Aug 9, 2023

This might be the original cause of #229.

@mienaiyami
Copy link
Owner

I forgot to type the reason in 299, but in short I forgot to re-add a single line after testing it, and it was responsible to removing the color element, now its just hiding it.

@zeoint
Copy link
Author

zeoint commented Aug 9, 2023

Its solved. Cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants