-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for opacity bar for font color in epub and live preview of it #138
Comments
A general question, why does the theme maker in app settings feel hard when changin colors compared to the theme system in epub reader settings? Is it a bug in the app theme system? |
as you can see, they are reflected in real time while in case of reader settings you need to click save to apply any changes in color. |
Cool. How much increase in cpu usage compared to now? |
UI will stop working for few seconds (over 10s easily). |
Oh my gosh, Should I close this issue then? or is there a win-win situation. By that, I meant live preview, 2 - 5% more present cpu usage, smooth theme system. |
I can add opacity though. |
Okay. Thanks. |
v2.8.0 supports it. But there will not be epub support as it is an older version. |
what are you referring to? |
I was talking about the smooth app theme system with live preview and normal cpu usage with no screen freezing. Since that was what the person asked. |
Yes, it works. So I am confused as to why it replaced with the hard theme system? |
Reference #82 . |
The old theme system was smooth therefore causing the change to happen quickly, hence uses more CPU resources. You just need to drag the cursor a bit slower for this new theme system to work quickly when you want to change the theme. |
I thought of a possible solution to it. So, when an epub file is opened,
|
Clicking outside the epub reader settings or closing the reader settings without clicking on the 'save and apply button' will dismiss the live preview. This can be observed while changing themes. As can be observed in the below video, the live preview happened, but I clicked outside the app settings / closed the app settings, thus dismissing the live preview. |
Oops, the above method I said might only be possible if the 'Load and show one chapter at a time (from TOC)' is the only way to read epub, otherwise the live preview will happen for the entire epub file causing the epub to freeze easily for 10 seconds like you said. |
No, even if its just one chapter it will still freeze. |
Cool. Then please ignore the live preview request. Thanks. |
Description of the new feature / enhancement
Sometimes the white font color is too bright to read with black / grey background.
So an opacity bar to adjust the font opactiy and a live preview of it, so I can save at the color, opacity I like.
It doesn't need to save it automatically, only save it by clicking on the save and apply button.
Scenario when this would be used?
To set the font color, opacity in epub.
Supporting information
By live preview, I want to see the change happening to the epub font, so that I could choose a perfect font color, opacity settings while reading epub's. Just like how it is done for theme maker. It shows live preview.
Suppose in the app theme maker, while changing the background it shows live preview and if save is not clicked it is not saved.
The same way for epub reader settings as it is now, only an opacity bar for font color and live preview is need to be added.
The text was updated successfully, but these errors were encountered: