Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Focus state issue with people-picker #434

Closed
vogtn opened this issue Jun 1, 2020 · 1 comment · Fixed by #461 or #489
Closed

[BUG] Focus state issue with people-picker #434

vogtn opened this issue Jun 1, 2020 · 1 comment · Fixed by #461 or #489
Assignees
Labels
1.3 Included in 1.3 release bug Something isn't working Priority: 0 State: Completed

Comments

@vogtn
Copy link
Contributor

vogtn commented Jun 1, 2020

Describe the bug
The mgt-people-picker uses a click state to determine styling and focus in the input area. However, there is a stopPropagation preventing other components from losing focus. This means if the mgt-teams-channel-picker is on the same page, the user is unable to switch focus between the components.

To Reproduce
Steps to reproduce the behavior:

  1. render both a mgt-teams-channel-picker and mgt-people-picker to a page.
  2. Click on the mgt-teams-channel-picker so that focus is received and the component starts loading.
  3. Click on the mgt-people-picker input so that it receives focus
  4. Observe both components UI seeming as if they are focused.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.
focusStateIssue

Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. edge, chrome, safari]
  • Framework [e.g. react, vue, none]
  • Context [e.g. Microsoft Teams, SharePoint, Office Add-ins, Web]
  • Version [e.g. 0.1]

Additional context
Add any other context about the problem here.

@vogtn vogtn added bug Something isn't working Needs: Triage 🔍 labels Jun 1, 2020
@vogtn vogtn self-assigned this Jun 1, 2020
@vogtn vogtn added the 1.3 Included in 1.3 release label Jun 1, 2020
@vogtn vogtn mentioned this issue Jun 3, 2020
5 tasks
@ghost ghost added the State: In Review label Jun 3, 2020
@nmetulev
Copy link
Contributor

nmetulev commented Jun 4, 2020

Closed by mistake

@ghost ghost locked as resolved and limited conversation to collaborators Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.3 Included in 1.3 release bug Something isn't working Priority: 0 State: Completed
Projects
None yet
3 participants