Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IDs from the url when fetching permissions #793

Closed
thewahome opened this issue Jan 13, 2021 · 1 comment · Fixed by #794
Closed

Remove IDs from the url when fetching permissions #793

thewahome opened this issue Jan 13, 2021 · 1 comment · Fixed by #794
Assignees
@thewahome
Labels
Area: Permissions Area: Telemetry priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days. promote type:bug Something isn't working

Comments

@thewahome
Copy link
Collaborator

thewahome commented Jan 13, 2021 •
edited by azure-boards bot
Loading

Is your feature request related to a problem? Please describe.
A URL sent to the permissions endpoint could have user data. To re-enable telemetry on the devx API, we need to redact the information from the URL similar to work done in auto-complete.

Describe the solution you'd like
Sanitize the URL before sending it to the devx API

Describe alternatives you've considered
Current: Turn off telemetry in the devx api

Additional context
This may not fully allow turning on telemetry for the Devx API since more work may be needed there. But the blocker from Graph Explorer would be removed

AB#7597
@ghost ghost added the ToTriage label Jan 13, 2021
@thewahome thewahome self-assigned this Jan 13, 2021
@ghost ghost removed the ToTriage label Jan 13, 2021
@ddyett
Copy link

ddyett commented Jan 13, 2021

i thought this was done already? If not we should work on this one shortly.

@thewahome thewahome mentioned this issue Jan 14, 2021
Merged
@adhiambovivian adhiambovivian added type:bug Something isn't working priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days. and removed Bug – P1 labels May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thewahome thewahome

Labels
Area: Permissions Area: Telemetry priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days. promote type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: sanitize url when fetching permissions microsoftgraph/microsoft-graph-explorer-v4
3 participants
@adhiambovivian @ddyett @thewahome