From 1f51f9c09e777b75bd730f264a19d51d987fcafb Mon Sep 17 00:00:00 2001 From: github-actions Date: Wed, 5 Apr 2023 16:16:48 +0000 Subject: [PATCH 01/19] Bump version to 8.1.0 --- package-lock.json | 2 +- package.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 97da2684f0..2ecf291202 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "graph-explorer-v2", - "version": "8.0.0", + "version": "8.1.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 7b6abb0911..13694f369f 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "graph-explorer-v2", - "version": "8.0.0", + "version": "8.1.0", "private": true, "dependencies": { "@augloop/types-core": "file:packages/types-core-2.16.189.tgz", @@ -136,4 +136,4 @@ "resolutions": { "@types/react": "17.0.44" } -} \ No newline at end of file +} From 3622b32a7b7a650cb663dd585b1977b8f9b19abb Mon Sep 17 00:00:00 2001 From: Elinor Date: Thu, 6 Apr 2023 10:59:55 +0300 Subject: [PATCH 02/19] return playwright test branch condition --- azure-pipelines.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/azure-pipelines.yml b/azure-pipelines.yml index 76b529afdb..d052a22f7b 100644 --- a/azure-pipelines.yml +++ b/azure-pipelines.yml @@ -101,6 +101,7 @@ jobs: - job: Two displayName: "Run playwright tests" + condition: eq(variables['isDev'], 'true') steps: - task: NodeTool@0 inputs: From 557db1949d89073195216037d74c0580e952742d Mon Sep 17 00:00:00 2001 From: EvansA Date: Fri, 7 Apr 2023 18:45:34 +0300 Subject: [PATCH 03/19] Fix: Missing return statement (#2507) --- .../query-runner/request/permissions/TabList.tsx | 2 +- src/tests/ui/anonymous-experiences/request.spec.ts | 11 +++++++++++ .../authenticated-experiences.spec.ts | 10 ++++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/app/views/query-runner/request/permissions/TabList.tsx b/src/app/views/query-runner/request/permissions/TabList.tsx index fd58e2e8a6..f2064c59d5 100644 --- a/src/app/views/query-runner/request/permissions/TabList.tsx +++ b/src/app/views/query-runner/request/permissions/TabList.tsx @@ -65,7 +65,7 @@ const TabList = ({ columns, classes, renderItemColumn, renderDetailsHeader, maxH } if(permissions.length === 0){ - displayNoPermissionsFoundMessage() + return displayNoPermissionsFoundMessage(); } return ( diff --git a/src/tests/ui/anonymous-experiences/request.spec.ts b/src/tests/ui/anonymous-experiences/request.spec.ts index 38338523bf..8765b2e3e1 100644 --- a/src/tests/ui/anonymous-experiences/request.spec.ts +++ b/src/tests/ui/anonymous-experiences/request.spec.ts @@ -322,6 +322,17 @@ test.describe('Permissions', () => { expect(await page.screenshot()).toMatchSnapshot(); const DirectoryPermission = page.locator('div[role="gridcell"]:has-text("Directory.Read.AllDirectory.Read.All")'); expect(DirectoryPermission).toBeDefined(); + }); + + test('should show a message for opening permissions panel when permission requested is not available', async () => { + const queryInput = page.locator('[aria-label="Query sample input"]'); + await queryInput.click(); + queryInput.fill('https://graph.microsoft.com/v1.0/userssssss'); + await page.locator('[aria-label="Modify permissions"]').click(); + await page.evaluate(() => document.fonts.ready); + await page.waitForTimeout(100); + expect(page.getByText('Permissions for the query are missing on this tab. Sign in to use the Select per')).toBeDefined(); + }) }) diff --git a/src/tests/ui/authenticated-experiences/authenticated-experiences.spec.ts b/src/tests/ui/authenticated-experiences/authenticated-experiences.spec.ts index ac5b2f1803..c6f9894527 100644 --- a/src/tests/ui/authenticated-experiences/authenticated-experiences.spec.ts +++ b/src/tests/ui/authenticated-experiences/authenticated-experiences.spec.ts @@ -45,6 +45,16 @@ test.describe('Request', () => { ]); expect(page5.url().indexOf('https://jwt.ms/')).toBeGreaterThan(-1); }) + + test('Permissions tab asks user to open permissions panel to view more permissions if missing on the tab', async () => { + const queryInput = authenticatedPage.locator('[aria-label="Query sample input"]'); + await queryInput.click(); + queryInput.fill('https://graph.microsoft.com/v1.0/userssssss'); + await authenticatedPage.locator('[aria-label="Modify permissions"]').click(); + await authenticatedPage.evaluate(() => document.fonts.ready); + await authenticatedPage.waitForTimeout(100); + expect(authenticatedPage.getByText('Permissions for the query are missing on this tab. Open the permissions panel to')).toBeDefined(); + }) }) test.describe.serial('Profile', () => { From 330040fd6b766454f1ededf2da924241db1f675c Mon Sep 17 00:00:00 2001 From: github-actions Date: Wed, 19 Apr 2023 08:24:15 +0000 Subject: [PATCH 04/19] Bump version to 8.2.0 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index f20d5ea2e3..acd5ab552b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "graph-explorer-v2", - "version": "8.1.0", + "version": "8.2.0", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 2b775a5d01..7abea76625 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "graph-explorer-v2", - "version": "8.1.0", + "version": "8.2.0", "private": true, "dependencies": { "@augloop/types-core": "file:packages/types-core-2.16.189.tgz", From 38c60bb13127a0e182b8b9fdf36d3c387d657d1b Mon Sep 17 00:00:00 2001 From: Elinor Date: Tue, 13 Jun 2023 11:34:37 +0300 Subject: [PATCH 05/19] Chore: Release 9.0.0 (#2619) * Chore: Update to 8.2.0 (#2520) * Fix: Add retry handler for revoking permissions (#2515) * Fix: Modify permissions tab resize (#2523) * Feature: Surface documentation links (#2219) * Task: Add support for persisting collections (#2525) * Chore: popups manager (#2514) * Task: support multiple collections (#2549) * Task: Show feedback - add to collections (#2555) * Chore: change "remove" aria label (#2558) * Chore: append unique paths to collection (#2560) * Fix: Collections reducer failing test logic (#2573) * Task: Reorder revoking permission event messages (#2526) * Fix: Persist sample body (#2550) * Fix: collection status for nodes with IDs (#2575) * add tests * get url for id nodes * Chore: Update failing snapshots (#2571) * Chore: Uppercase methods (#2578) * Task: Dependabot upgrades for May (#2557) * Task: Add support for uploading postman collections (#2579) * Fix: Remove use of external label (#2582) * Chore: utilise resource paths (#2584) * Chore: ensure unique paths (#2586) * Chore: Dependabot upgrades - June (#2612) * Chore: Clear network error message (#2615) * Task: Add new permissions scopeType (#2585) * Bump version to 9.0.0 --------- Co-authored-by: EvansA Co-authored-by: Charles Wahome --- .eslintrc.js | 5 +- .github/fabricbot.json | 18 - config/webpack.config.js | 4 - package-lock.json | 2926 ++++++++--------- package.json | 79 +- playwright.config.ts | 2 +- src/app/middleware/localStorageMiddleware.ts | 47 +- .../autocomplete-action-creators.spec.ts | 4 +- .../collections-action-creators.spec.ts | 87 + .../actions/collections-action-creators.ts | 26 + .../permissions-action-creator.spec.ts | 91 +- .../actions/permissions-action-creator.ts | 172 +- .../permissions-action-creator.util.ts | 133 +- .../permissions-panel-action-creator.spec.ts | 20 - .../permissions-panel-action-creator.ts | 9 - .../resource-explorer-action-creators.spec.ts | 56 +- .../resource-explorer-action-creators.ts | 27 +- .../context/popups-context/PopupsContext.tsx | 21 + .../services/context/popups-context/index.ts | 70 + .../context/popups-context/reducedPopups.ts | 29 + src/app/services/hooks/index.ts | 5 + src/app/services/hooks/usePopups.ts | 39 + .../reducers/collections-reducer.spec.ts | 123 + .../services/reducers/collections-reducer.ts | 46 + .../reducers/collections-reducer.util.ts | 16 + src/app/services/reducers/index.ts | 4 +- .../permissions-panel-reducer.spec.ts | 17 - .../reducers/permissions-panel-reducer.ts | 11 - .../reducers/resources-reducer.spec.ts | 110 +- .../services/reducers/resources-reducer.ts | 38 +- src/app/services/redux-constants.ts | 1 + src/app/utils/fetch-retry-handler.ts | 23 + src/app/utils/resources/resources-filter.ts | 5 +- src/app/utils/resources/resources.json | 423 +++ src/app/views/App.tsx | 177 +- .../views/authentication/profile/Profile.tsx | 29 +- .../common/error-boundary/ErrorBoundary.tsx | 42 + src/app/views/common/error-boundary/index.ts | 3 + src/app/views/common/popups/DialogWrapper.tsx | 49 + src/app/views/common/popups/ModalWrapper.tsx | 44 + src/app/views/common/popups/PanelWrapper.tsx | 78 + src/app/views/common/popups/PopupsWrapper.tsx | 68 + src/app/views/common/popups/popups.types.ts | 9 + src/app/views/common/registry/popups.tsx | 14 + src/app/views/main-header/MainHeader.tsx | 11 +- .../views/main-header/settings/Settings.tsx | 74 +- .../main-header/settings/ThemeChooser.tsx | 61 + src/app/views/query-runner/QueryRunner.tsx | 17 +- .../query-runner/query-input/QueryInput.tsx | 6 +- .../auto-complete/suffix/HintList.tsx | 46 - .../auto-complete/suffix/SuffixRenderer.tsx | 142 +- .../suffix/documentation.spec.ts | 41 + .../auto-complete/suffix/documentation.ts | 89 + .../auto-complete/suffix/suffix-util.ts | 86 - .../query-input/share-query/ShareButton.tsx | 49 + .../query-input/share-query/ShareQuery.tsx | 107 +- .../query-input/share-query/index.ts | 4 +- .../views/query-runner/request/Request.tsx | 30 +- .../request/permissions/PanelList.tsx | 237 -- .../request/permissions/Permission.tsx | 379 --- .../request/permissions/PermissionItem.tsx | 162 + .../request/permissions/Permissions.Full.tsx | 210 ++ .../request/permissions/Permissions.Query.tsx | 164 + .../request/permissions/TabList.tsx | 105 - .../request/permissions/columns.tsx | 138 + .../query-runner/request/permissions/index.ts | 4 +- .../views/query-runner/request/request.scss | 1 + src/app/views/sidebar/Sidebar.styles.ts | 5 +- .../resource-explorer/ResourceExplorer.tsx | 167 +- .../resource-explorer/ResourceLink.tsx | 226 +- .../{panels => collection}/Paths.tsx | 7 +- .../collection/PreviewCollection.tsx | 92 + .../collection/UploadCollection.tsx | 125 + .../collection/postman.util.spec.ts | 41 + .../{panels => collection}/postman.util.ts | 39 +- .../command-options/CommandOptions.tsx | 32 +- .../resource-explorer/panels/PathsReview.tsx | 114 - .../panels/postman.util.spec.ts | 17 - .../resource-explorer.utils.spec.ts | 52 +- .../resource-explorer.utils.ts | 110 +- .../resourcelink.utils.spec.ts | 139 + .../resource-explorer/resourcelink.utils.ts | 30 + .../sidebar/resource-explorer/resources.json | 233 -- .../resource-explorer/resources.styles.ts | 6 +- .../sidebar/sample-queries/SampleQueries.tsx | 2 +- src/index.tsx | 55 +- src/messages/GE.json | 18 +- src/modules/cache/collections.cache.ts | 51 + src/modules/cache/resources.cache.spec.ts | 14 +- src/modules/cache/resources.cache.ts | 16 +- src/telemetry/component-names.ts | 2 +- .../ui/anonymous-experiences/request.spec.ts | 26 +- .../ui/anonymous-experiences/sidebar.spec.ts | 44 +- ...-resource-to-collection-1-Chrome-win32.png | Bin 67422 -> 0 bytes ...resource-to-collection-1-Ms-Edge-win32.png | Bin 90847 -> 0 bytes ...-resource-to-collection-2-Chrome-win32.png | Bin 66442 -> 0 bytes ...resource-to-collection-2-Ms-Edge-win32.png | Bin 89037 -> 0 bytes ...-resource-to-collection-3-Chrome-win32.png | Bin 68713 -> 0 bytes ...resource-to-collection-3-Ms-Edge-win32.png | Bin 91482 -> 0 bytes ...-resource-to-collection-4-Chrome-win32.png | Bin 65753 -> 0 bytes ...resource-to-collection-4-Ms-Edge-win32.png | Bin 86948 -> 0 bytes ...-resource-to-collection-5-Chrome-win32.png | Bin 32127 -> 0 bytes ...resource-to-collection-5-Ms-Edge-win32.png | Bin 81910 -> 0 bytes ...-resource-to-collection-6-Chrome-win32.png | Bin 66652 -> 0 bytes ...resource-to-collection-6-Ms-Edge-win32.png | Bin 90541 -> 0 bytes ...olate-button-is-clicked-1-Chrome-win32.png | Bin 66519 -> 0 bytes ...late-button-is-clicked-1-Ms-Edge-win32.png | Bin 90469 -> 0 bytes ...olate-button-is-clicked-2-Chrome-win32.png | Bin 69418 -> 0 bytes ...late-button-is-clicked-2-Ms-Edge-win32.png | Bin 92126 -> 0 bytes ...olate-button-is-clicked-3-Chrome-win32.png | Bin 47027 -> 0 bytes ...late-button-is-clicked-3-Ms-Edge-win32.png | Bin 58971 -> 0 bytes ...olate-button-is-clicked-4-Chrome-win32.png | Bin 67261 -> 0 bytes ...late-button-is-clicked-4-Ms-Edge-win32.png | Bin 90705 -> 0 bytes ...lorer-button-is-clicked-1-Chrome-win32.png | Bin 40166 -> 40940 bytes ...orer-button-is-clicked-1-Ms-Edge-win32.png | Bin 90681 -> 52582 bytes ...lorer-button-is-clicked-2-Chrome-win32.png | Bin 66309 -> 61853 bytes ...orer-button-is-clicked-2-Ms-Edge-win32.png | Bin 88840 -> 82750 bytes ...lorer-button-is-clicked-3-Chrome-win32.png | Bin 66459 -> 62034 bytes ...orer-button-is-clicked-3-Ms-Edge-win32.png | Bin 90412 -> 84379 bytes ...a-versions-of-resources-1-Chrome-win32.png | Bin 66615 -> 62078 bytes ...-versions-of-resources-1-Ms-Edge-win32.png | Bin 90647 -> 84397 bytes ...a-versions-of-resources-2-Chrome-win32.png | Bin 67088 -> 63879 bytes ...-versions-of-resources-2-Ms-Edge-win32.png | Bin 94254 -> 87510 bytes ...ple-query-when-clicked-1-Ms-Edge-win32.png | Bin 51006 -> 101059 bytes .../authenticated-experiences.spec.ts | 6 +- .../responsiveness/mobile-responsive.spec.ts | 9 +- ...en-tab-in-overflow-menu-1-Chrome-win32.png | Bin 36664 -> 36311 bytes ...n-tab-in-overflow-menu-1-Ms-Edge-win32.png | Bin 36708 -> 36318 bytes ...ns-tab-in-overflow-menu-1-Chrome-win32.png | Bin 53909 -> 56636 bytes ...s-tab-in-overflow-menu-1-Ms-Edge-win32.png | Bin 53887 -> 56645 bytes ...rd-tab-in-overflow-menu-1-Chrome-win32.png | Bin 30619 -> 30298 bytes ...d-tab-in-overflow-menu-1-Ms-Edge-win32.png | Bin 30607 -> 30330 bytes ...rd-tab-in-overflow-menu-2-Chrome-win32.png | Bin 34660 -> 34116 bytes ...d-tab-in-overflow-menu-2-Ms-Edge-win32.png | Bin 34484 -> 34149 bytes ...rd-tab-in-overflow-menu-3-Chrome-win32.png | Bin 37040 -> 0 bytes ...d-tab-in-overflow-menu-3-Ms-Edge-win32.png | Bin 36978 -> 0 bytes ...ts-tab-in-overflow-menu-1-Chrome-win32.png | Bin 37002 -> 35858 bytes ...s-tab-in-overflow-menu-1-Ms-Edge-win32.png | Bin 37041 -> 35873 bytes ...nt-tab-in-overflow-menu-1-Chrome-win32.png | Bin 44611 -> 47678 bytes ...t-tab-in-overflow-menu-1-Ms-Edge-win32.png | Bin 44606 -> 47678 bytes ...nt-tab-in-overflow-menu-1-Chrome-win32.png | Bin 23750 -> 23466 bytes ...t-tab-in-overflow-menu-1-Ms-Edge-win32.png | Bin 23739 -> 23490 bytes ...should-have-history-tab-1-Chrome-win32.png | Bin 24971 -> 24972 bytes ...hould-have-history-tab-1-Ms-Edge-win32.png | Bin 24971 -> 24972 bytes ...ould-have-resources-tab-1-Chrome-win32.png | Bin 44947 -> 41948 bytes ...uld-have-resources-tab-1-Ms-Edge-win32.png | Bin 44947 -> 41974 bytes ...have-sample-queries-tab-1-Chrome-win32.png | Bin 43177 -> 41675 bytes ...ave-sample-queries-tab-1-Ms-Edge-win32.png | Bin 43167 -> 41533 bytes src/types/query-response.ts | 6 - src/types/resources.ts | 31 +- src/types/root.ts | 4 +- 151 files changed, 5074 insertions(+), 4008 deletions(-) create mode 100644 src/app/services/actions/collections-action-creators.spec.ts create mode 100644 src/app/services/actions/collections-action-creators.ts delete mode 100644 src/app/services/actions/permissions-panel-action-creator.spec.ts delete mode 100644 src/app/services/actions/permissions-panel-action-creator.ts create mode 100644 src/app/services/context/popups-context/PopupsContext.tsx create mode 100644 src/app/services/context/popups-context/index.ts create mode 100644 src/app/services/context/popups-context/reducedPopups.ts create mode 100644 src/app/services/hooks/index.ts create mode 100644 src/app/services/hooks/usePopups.ts create mode 100644 src/app/services/reducers/collections-reducer.spec.ts create mode 100644 src/app/services/reducers/collections-reducer.ts create mode 100644 src/app/services/reducers/collections-reducer.util.ts delete mode 100644 src/app/services/reducers/permissions-panel-reducer.spec.ts delete mode 100644 src/app/services/reducers/permissions-panel-reducer.ts create mode 100644 src/app/utils/fetch-retry-handler.ts create mode 100644 src/app/utils/resources/resources.json create mode 100644 src/app/views/common/error-boundary/ErrorBoundary.tsx create mode 100644 src/app/views/common/error-boundary/index.ts create mode 100644 src/app/views/common/popups/DialogWrapper.tsx create mode 100644 src/app/views/common/popups/ModalWrapper.tsx create mode 100644 src/app/views/common/popups/PanelWrapper.tsx create mode 100644 src/app/views/common/popups/PopupsWrapper.tsx create mode 100644 src/app/views/common/popups/popups.types.ts create mode 100644 src/app/views/common/registry/popups.tsx create mode 100644 src/app/views/main-header/settings/ThemeChooser.tsx delete mode 100644 src/app/views/query-runner/query-input/auto-complete/suffix/HintList.tsx create mode 100644 src/app/views/query-runner/query-input/auto-complete/suffix/documentation.spec.ts create mode 100644 src/app/views/query-runner/query-input/auto-complete/suffix/documentation.ts delete mode 100644 src/app/views/query-runner/query-input/auto-complete/suffix/suffix-util.ts create mode 100644 src/app/views/query-runner/query-input/share-query/ShareButton.tsx delete mode 100644 src/app/views/query-runner/request/permissions/PanelList.tsx delete mode 100644 src/app/views/query-runner/request/permissions/Permission.tsx create mode 100644 src/app/views/query-runner/request/permissions/PermissionItem.tsx create mode 100644 src/app/views/query-runner/request/permissions/Permissions.Full.tsx create mode 100644 src/app/views/query-runner/request/permissions/Permissions.Query.tsx delete mode 100644 src/app/views/query-runner/request/permissions/TabList.tsx create mode 100644 src/app/views/query-runner/request/permissions/columns.tsx rename src/app/views/sidebar/resource-explorer/{panels => collection}/Paths.tsx (92%) create mode 100644 src/app/views/sidebar/resource-explorer/collection/PreviewCollection.tsx create mode 100644 src/app/views/sidebar/resource-explorer/collection/UploadCollection.tsx create mode 100644 src/app/views/sidebar/resource-explorer/collection/postman.util.spec.ts rename src/app/views/sidebar/resource-explorer/{panels => collection}/postman.util.ts (50%) delete mode 100644 src/app/views/sidebar/resource-explorer/panels/PathsReview.tsx delete mode 100644 src/app/views/sidebar/resource-explorer/panels/postman.util.spec.ts create mode 100644 src/app/views/sidebar/resource-explorer/resourcelink.utils.spec.ts create mode 100644 src/app/views/sidebar/resource-explorer/resourcelink.utils.ts delete mode 100644 src/app/views/sidebar/resource-explorer/resources.json create mode 100644 src/modules/cache/collections.cache.ts delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-1-Chrome-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-1-Ms-Edge-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-2-Chrome-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-2-Ms-Edge-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-3-Chrome-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-3-Ms-Edge-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-4-Chrome-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-4-Ms-Edge-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-5-Chrome-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-5-Ms-Edge-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-6-Chrome-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-add-a-resource-to-collection-6-Ms-Edge-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-1-Chrome-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-1-Ms-Edge-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-2-Chrome-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-2-Ms-Edge-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-3-Chrome-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-3-Ms-Edge-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-4-Chrome-win32.png delete mode 100644 src/tests/ui/anonymous-experiences/sidebar.spec.ts-snapshots/Resources-Explorer-should-isolate-a-resource-when-the-isolate-button-is-clicked-4-Ms-Edge-win32.png delete mode 100644 src/tests/ui/responsiveness/mobile-responsive.spec.ts-snapshots/Response-area-navigation-should-have-adaptive-card-tab-in-overflow-menu-3-Chrome-win32.png delete mode 100644 src/tests/ui/responsiveness/mobile-responsive.spec.ts-snapshots/Response-area-navigation-should-have-adaptive-card-tab-in-overflow-menu-3-Ms-Edge-win32.png diff --git a/.eslintrc.js b/.eslintrc.js index e1c7102942..75ab9b14d8 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -148,7 +148,10 @@ module.exports = { 'spaced-comment': 'off', 'use-isnan': 'error', 'valid-typeof': 'off', - 'react/react-in-jsx-scope': 'off' + 'react/react-in-jsx-scope': 'off', + 'react/no-unstable-nested-components': [ + 'off', { 'allowAsProps': true } + ] }, settings: { react: { diff --git a/.github/fabricbot.json b/.github/fabricbot.json index 5da773ebcc..7410dd93cb 100644 --- a/.github/fabricbot.json +++ b/.github/fabricbot.json @@ -1065,12 +1065,6 @@ "parameters": { "label": "API: Graph" } - }, - { - "name": "hasLabel", - "parameters": { - "label": "external" - } } ] }, @@ -1325,18 +1319,6 @@ "label": "API: Graph" } }, - { - "name": "hasLabel", - "parameters": { - "label": "external" - } - }, - { - "name": "noLabel", - "parameters": { - "label": "Service issue" - } - }, { "name": "noActivitySince", "parameters": { diff --git a/config/webpack.config.js b/config/webpack.config.js index 6d179bbb05..cb8d732f26 100644 --- a/config/webpack.config.js +++ b/config/webpack.config.js @@ -17,7 +17,6 @@ const paths = require('./paths'); const getClientEnvironment = require('./env'); const ModuleNotFoundPlugin = require('react-dev-utils/ModuleNotFoundPlugin'); const ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin'); -const MonacoWebpackPlugin = require('monaco-editor-webpack-plugin'); const ESLintPlugin = require('eslint-webpack-plugin'); // Source maps are resource heavy and can cause out of memory issue for large source files. @@ -416,9 +415,6 @@ module.exports = function (webpackEnv) { new webpack.optimize.LimitChunkCountPlugin({ maxChunks: 1 }), - new MonacoWebpackPlugin({ - languages: ['json', 'javascript', 'java', 'csharp', 'html', 'powershell', 'go'] - }), // Generates an `index.html` file with the