Fix: screen reader announces search results status message #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddyett
reviewed
Jul 20, 2020
| @@ -37,6 +40,7 @@ const PanelList = ({ messages, permissions, | |||
| searchValueChanged(event, newValue)} | |||
| styles={{ field: { paddingLeft: 10 } }} | |||
| /> | |||
| <Announced message={`${permissions.length} search results available.`}/> | |||
There was a problem hiding this comment.
Since it's only a message that is being read, I tested this out with a Spanish narrator, and the narrator translates it itself
jobala
reviewed
Jul 21, 2020
| @@ -1,4 +1,7 @@ | |||
| import { DetailsList, DetailsListLayoutMode, IColumn, Label, SearchBox, SelectionMode } from 'office-ui-fabric-react'; | |||
| import { | |||
| Announced, DetailsList, DetailsListLayoutMode, IColumn, | |||
There was a problem hiding this comment.
Place each imported class on a newline.
import {
Announced,
DetailList,
...
} from '..'
thewahome
reviewed
Jul 21, 2020
| @@ -37,6 +40,7 @@ const PanelList = ({ messages, permissions, | |||
| searchValueChanged(event, newValue)} | |||
| styles={{ field: { paddingLeft: 10 } }} | |||
| /> | |||
| <Announced message={`${permissions.length} search results available.`}/> | |||
There was a problem hiding this comment.
Does the announce message get triggered only when a search has happened?
thewahome
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added announced component which enables a screen reader to announce the 'Search sample queries' and 'Search permissions' (search result) information.
Testing Instructions