Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference delete scenario is not supported by the SDK #471

Closed
zengin opened this issue Mar 3, 2021 · 5 comments
Closed

Reference delete scenario is not supported by the SDK #471

zengin opened this issue Mar 3, 2021 · 5 comments
Assignees

Comments

@zengin
Copy link
Contributor

zengin commented Mar 3, 2021

There is no generated code available to support:

DELETE /groups/{id}/acceptedSenders/$ref?$id=https://graph.microsoft.com/v1.0/users/{user-id}

https://docs.microsoft.com/en-us/graph/api/group-delete-acceptedsenders?view=graph-rest-1.0&tabs=csharp
AB#8405

@ghost ghost added the ToTriage label Mar 3, 2021
@baywet
Copy link
Member

baywet commented Nov 17, 2021

It should fix it since we have the request builder for it. https://github.com/microsoftgraph/msgraph-sdk-go/blob/main/groups/item/acceptedsenders/ref/ref_request_builder.go

However there does seem to be a bug in the conversion process. microsoft/OpenAPI.NET.OData#128

@baywet
Copy link
Member

baywet commented Nov 27, 2023

@andrueastman it looks like the snippet is still not being generated for this one.
To me this is either an issue in the conversion process (path segments are not being projected) or in the snippets generation.
Can you validate that specific path is in the description? Based on that, we'll transfer the issue.

@andrueastman
Copy link
Member

@baywet
The snippet fails to generate here because there is no DELETE method for /groups/{group-id}/acceptedSenders/$ref (only GET and POST).
The DELETE method, however does exist on the path /groups/{group-id}/acceptedSenders/{directoryObject-id}/$ref as is the expectation with this issue where it's added on the item and not on the collection.

There may be a conversion issue or a missing annotation that we would need to investigate so that the operation appears on the collection with the relevant query parameter as shown in the snippet.

@baywet
Copy link
Member

baywet commented Nov 27, 2023

Thanks for reverting here.
I was referring to the first case. Do you think we should transfer this to the metadata repo then?

@andrueastman
Copy link
Member

After looking into this abit more, this is probably a conversion library issue given the original work/issue here and the PR here the conversion library looks like it will only add the DELETE operation on the key segment but not on a collection valued one like in the example ~/entityset/{key}/collection-valued-Nav/$ref?$id ={navKey}

If, it's okay, I'll close this for now and we can follow this one up at microsoft/OpenAPI.NET.OData#453 as this one looks to definitely need conversion library support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants