Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinDirStat - Make InstallationNotes more accurate #174360

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Sep 19, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 19, 2024
auto-merge was automatically disabled September 19, 2024 23:23

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 19, 2024
@Trenly Trenly changed the title WinDirStat - Better InstallNotes Formatting WinDirStat - Make InstallationNotes more accurate Sep 19, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 20, 2024
@stephengillie
Copy link
Collaborator

Hi @Trenly,

This manifest removes the DisplayVersion from the AppsAndFeaturesEntries, which is present in previous manifest versions. This entry should be added to this version, to maintain version matching, and prevent the 'upgrade always available' situation with this package.

(Automated response - build 896.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 20, 2024
@Trenly
Copy link
Contributor Author

Trenly commented Sep 20, 2024

Hi @Trenly,

This manifest removes the DisplayVersion from the AppsAndFeaturesEntries, which is present in previous manifest versions. This entry should be added to this version, to maintain version matching, and prevent the 'upgrade always available' situation with this package.

(Automated response - build 896.)

Pretty sure it doesn't

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 20, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Sep 20, 2024
@wingetbot wingetbot added the Validation-Completed Validation passed label Sep 20, 2024
@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Sep 20, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Sep 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 9564cff into microsoft:master Sep 20, 2024
2 checks passed
@Trenly Trenly deleted the nonewline branch September 20, 2024 16:15
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@stephengillie
Copy link
Collaborator

Pretty sure it doesn't

Apologies - that check isn't supposed to fire when there's no installer.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants