Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommendation for users to move away from WinDirStat #174213

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Sep 19, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


There have now been a few issues filed indicating confusion around the behavior of WinDirStat and the version being unknown.

Because the last release of WinDirStat was in 2016, it should be safe to assume that it is not in active development and no new updates for the package will be coming. However, another package - WizTree - provides the same functionality as WinDirStat but is newer, much faster, and is still being patched and developed upon.

This PR adds an installation note to help reduce confusion and point users towards the newer software if they should choose to install it.

Related to microsoft/winget-cli#1899

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@wingetbot wingetbot added the URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation label Sep 19, 2024
@wingetbot
Copy link
Collaborator

Url validation error

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 19, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Author-Feedback This needs a response from the author. URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation labels Sep 19, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit b61ea5b into microsoft:master Sep 19, 2024
2 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Lonniebiz
Copy link

Lonniebiz commented Sep 19, 2024

Because the last release of WinDirStat was in 2016, it should be safe to assume that it is not in active development and no new updates for the package will be coming. However, another package - WizTree - provides the same functionality as WinDirStat but is newer, much faster, and is still being patched and developed upon.

This PR adds an installation note to help reduce confusion and point users towards the newer software if they should choose to install it.

While WizTree may be faster, and more actively developed, it isn't open source (like WinDirStat is). Users like myself may prefer WinDirStat for this reason alone (even if it is slower).

@Trenly
Copy link
Contributor Author

Trenly commented Sep 19, 2024

That is true, which is why I just added it as a note so that users can make their own decisions about the software they choose to install

@cvrebert
Copy link
Contributor

it should be safe to assume that it is not in active development and no new updates for the package will be coming

They've been making alpha/beta releases periodically this year (https://github.com/windirstat/windirstat-next/releases ). Likewise for commits (https://github.com/windirstat/windirstat/commits/master/ ), including one yesterday.

There have now been a few issues filed indicating confusion around the behavior of WinDirStat and the version being unknown.

Presumably they'll have that fixed when they finally make their next major stable release: windirstat/windirstat#46
Seems they're switching to a Wix installer.

@Trenly
Copy link
Contributor Author

Trenly commented Sep 19, 2024

Perfect; Once a new version is released I'll update the manifest and remove this note, especially since there isn't a set date for the 2.0.0 version as far as I can tell

@NoMoreFood
Copy link
Contributor

@Trenly The next two months is my goal. Would you like me to take over updating this when the release is ready? I would appreciate you removing the note now since it is false.

@Lonniebiz
Copy link

Lonniebiz commented Sep 27, 2024

@NoMoreFood: Couldn't you do a quick release of WinDirStat, that is exactly like the current version provided in winget except that it merely sets that version registry entry that winget needs to remain aware of the installed version of WinDirstat?

Perhaps that alone is more work than it might appear to me, and it is just better to wait.

As for WinDirStat and "active development", I've used it for years and it doesn't bother me much that it hasn't changed since 2016. When something works well for its purpose it doesn't require too much active development. Plus, it is open source, and I typically favor that over closed source alternatives (that's more of a priority to me than performance in this case).

While I'm glad to be informed of the existence WizTree, I don't like a package manager recommending a proprietary application as an alternative to an open source one unless this difference is explicitly made clear. I guess that's just my preference, but now that the note has been discovered untrue, that's probably a more agreeable reason to go ahead and remove it.

@aisgbnok
Copy link
Contributor

aisgbnok commented Sep 27, 2024

FYI, @Trenly updated the accuracy of this note last week (the day after this PR):

As I understand it, this note aimed to minimize user confusion and reduce the amount of issues being opened in this microsoft/winget-pkgs repository. While I agree that this note may have seemed biased, the updated note appears to be a reasonable compromise until 2.0.0 lands.

Note as of 2024-09-20T17:11:57Z:

Installation Notes: Because this software does not write a version to the registry, WinGet is not able to determine the installed version. This will be fixed in the next release of WinDirStat. See windirstat/windirstat#75 for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants