Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AkeoConsulting.Rufus version 3.14.1788 #14610

Conversation

TheGift73
Copy link

@TheGift73 TheGift73 commented May 30, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost
Copy link

ghost commented May 30, 2021

CLA assistant check
All CLA requirements met.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KaranKad KaranKad mentioned this pull request May 30, 2021
@KaranKad
Copy link
Contributor

AkeoConsulting is not correct name for the publisher.

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label May 30, 2021
@ghost ghost assigned TheGift73 May 30, 2021
@ghost
Copy link

ghost commented May 30, 2021

Hello @TheGift73,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator.

@TheGift73
Copy link
Author

TheGift73 commented May 30, 2021

PS C:\Users\Dickie PC> winget install --manifest "C:\Users\Dickie PC\manifests\a\AkeoConsulting\Rufus\3.14.1788"
Found Rufus [AkeoConsulting.Rufus]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licences to, third-party packages.
Downloading https://github.com/pbatard/rufus/releases/download/v3.14/rufus-3.14.exe
  ██████████████████████████████  1.11 MB / 1.11 MB
Successfully verified installer hash
Starting package install...
Successfully installed
PS C:\Users\Dickie PC>

Ran winget install --manifest "C:\Users\Dickie PC\manifests\a\AkeoConsulting\Rufus\3.14.1788" in Powershell and installed fine on my end (except for UAT prompt)

When I ran winget validate --manifest "C:\Users\Dickie PC\manifests\a\AkeoConsulting\Rufus\3.14.1788" it succeeded with the following warning: #Note it installed and opened after running the command

Manifest validation succeeded with warnings.
Manifest Warning: Silent and SilentWithProgress switches are not specified for InstallerType exe. Please make sure the installer can run unattended.

This is my first pull request and just trying to assist the community for winget being released/updated for Windows. Noticed that Rufus wasn't on the repository list, so ran the winget install wingetcreate followed by wingetcreate new https://github.com/pbatard/rufus/releases/download/v3.14/rufus-3.14.exe to get it added so other users can install easily via winget.

@KaranKad Got the publishers name for Rufus from the exe properties under the Digital Signatures tab

If I have errored in this, let me know so I know for the future.

@KaranKad
Copy link
Contributor

Rufus exists at manifests/r/Rufus/Rufus. AkeoConsulting is just name of the company that the application is licensed under.

@TheGift73
Copy link
Author

TheGift73 commented May 30, 2021

@KaranKad Ah, sorry, I should have check correctly.

Had an email back from Pete Batard (creator of Rufus) after letting him know that I just did a pull request for winget install with the following:

"Hi Richard,

That sounds good, but I am not planning to get involved with Winget
packages at the moment, so I will leave it to users like you to sort the
specifics of creating a package.

Regards,

/Pete"

So will leave the correct specifics of a correct implementation of this to others here as I guess I did mine incorrectly.

Thank you though for the reply and I'll make sure to check for next time.

@KaranKad
Copy link
Contributor

Yeah no problem, thanks for contributing.

@OfficialEsco
Copy link
Contributor

@TheGift73

This is my first pull request and just trying to assist the community for winget being released/updated for Windows. Noticed that Rufus wasn't on the repository list

What repository list?
image

The Rufus exe is not a installer, its just a portable program so it requires the appx which installs as a Windows Store app.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants