Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NitroPDFIncNitroPDFPtyLtd version 5.1.0.2 #14551

Closed
wants to merge 2 commits into from
Closed

NitroPDFIncNitroPDFPtyLtd version 5.1.0.2 #14551

wants to merge 2 commits into from

Conversation

techflashYT
Copy link
Contributor

@techflashYT techflashYT commented May 30, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label May 30, 2021
@ghost ghost assigned techflashYT May 30, 2021
@ghost
Copy link

ghost commented May 30, 2021

Hello @sanikdah,
During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator.

@KaranKad
Copy link
Contributor

Don't use comma (,) in name

@techflashYT
Copy link
Contributor Author

Huh, is there any info on why it didn't install without user input? It did when I was testing it locally.

@KaranKad
Copy link
Contributor

The InstallerUrl: you provided is gonna expire after some time.

@techflashYT
Copy link
Contributor Author

Alright, I'll see if I can deal with that tomorrow, its already past midnight for me and I have to go to bed once I get this last piece of software up.

@KaranKad KaranKad mentioned this pull request May 30, 2021
@techflashYT
Copy link
Contributor Author

Alright so now let me deal with the commas in the name and files.

@techflashYT
Copy link
Contributor Author

Can you show me how to make the URL not expire? I tried just getting rid of the ?Expires=1622391378 part and that without the ? and still didnt work.

@techflashYT
Copy link
Contributor Author

ok nevermind I found one that won't expire

@techflashYT
Copy link
Contributor Author

alright and the sha256 matches

@techflashYT techflashYT changed the title NitroPDF,Inc,NitroPDF,Pty,Ltd.PrimoPDF version 5.1.0.2 NitroPDFIncNitroPDFPtyLtd version 5.1.0.2 May 30, 2021
…ml to NitroPDFIncNitroPDFPtyLtd.installer.yaml
@ghost ghost removed Needs: Attention Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels May 30, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label May 30, 2021
@ghost
Copy link

ghost commented May 30, 2021

Hello @sanikdah,
The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.0 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode (https://code.visualstudio.com/) to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator Preview.

For details on the specific error, see the details link below in the build pipeline.

@techflashYT
Copy link
Contributor Author

I'm just gonna remake it this is such a pain to edit.

@ghost ghost added the Needs: Attention label May 30, 2021
@techflashYT techflashYT deleted the autogenerated/NitroPDF,Inc,NitroPDF,Pty,Ltd.PrimoPDF/32ef2253-24ee-466a-94c6-6a97d4e1cad4 branch May 30, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Manifest-Validation-Error Manifest validation failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants