Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: RealVNC.VNCServer version 7.8.0 #133228

Merged
merged 2 commits into from
Jan 15, 2024
Merged

New version: RealVNC.VNCServer version 7.8.0 #133228

merged 2 commits into from
Jan 15, 2024

Conversation

BiosPlus
Copy link
Contributor

@BiosPlus BiosPlus commented Jan 8, 2024 •
edited
Loading

Pull request has been created with Komac v1.11.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 8, 2024
@stephengillie
Copy link
Collaborator

Hi @BiosPlus,

This PR's version number 7.8.0 has 3 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 7.6.0.50657, which has 4 parameters.

Is this intentional?

(Automated response - build 522)

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jan 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jan 13, 2024
@BiosPlus
Copy link
Contributor Author

The URL for these downloads uses semantic versioning without the build number, each of the previous URLS and versions repo'd by winget only had one version per patch anyhow. Are build numbers absolutely necessary in this case?

image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed No-Recent-Activity No activity has occurred on this work item for seven days. Needs-Author-Feedback This needs a response from the author. labels Jan 14, 2024
@stephengillie
Copy link
Collaborator

Build numbers aren't necessary, and indeed developers are free to change the number of parameters at will. We've had an issue where parameters were being added or omitted by automation, and this causes issues with version matching. So to combat this, I have automation that asks when there's a mismatch. Sorry for any concern caused.

@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 680051e into microsoft:master Jan 15, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jan 15, 2024
@BiosPlus BiosPlus deleted the RealVNC.VNCServer-7.8.0-1B98A1AFF1194F1BDF732649CCF03E525C8A3460 branch January 16, 2024 00:13
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Update Request]: RealVNC.VNCServer
3 participants
@BiosPlus @wingetbot @stephengillie