Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Request]: Microsoft.Dotnet.* (update CDN urls) #202037

Open
a-mnich opened this issue Dec 24, 2024 · 4 comments
Open

[Update Request]: Microsoft.Dotnet.* (update CDN urls) #202037

a-mnich opened this issue Dec 24, 2024 · 4 comments
Labels
Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated

Comments

@a-mnich
Copy link
Contributor

a-mnich commented Dec 24, 2024

What type of update are you requesting?

Something else not listed

Current Package Identifier

Microsoft.Dotnet.*

Package Version

multiple

Please describe the changes you would like to see

As announced in dotnet/core#9671 the hoster of the CDNs https://dotnetcli.azureedge.net/ and https://dotnetbuilds.azureedge.net/ will soon seize operations due to bankrupcy.
It is recommended that users switch to the new CDN domains as quickly as possible.
While a majority of the newest versions Microsoft.Dotnet.*packages has already been switched to the new CDN by @mthalman (e.g. in PR #200316) there are still a lot of packages with the old domains remaining.

  • A GitHub Search for https://dotnetcli.azureedge.net/ gets results in 620 files within this repository.
  • https://dotnetbuilds.azureedge.net/ isn't used within winget-pkgs

Action steps:
Open PRs to switch the installer domain from https://dotnetcli.azureedge.net/ to builds.dotnet.microsoft.com for all packages found in the GitHub search.

@a-mnich a-mnich added Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated labels Dec 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Dec 24, 2024
@flo7000
Copy link

flo7000 commented Dec 25, 2024

hello,
i'd like to do that but i have a question:
i should do a PR for each package, right?

and starting at which point of the path do i count it as a whole package? at "SDK" in that example?
/manifests/m/Microsoft/DotNet/SDK/6/6.0.122/Microsoft.DotNet.SDK.6.installer.yaml

and use the whole link "https://builds.dotnet.microsoft.com" (and the rest of the installer path stays the same right?)

@Dragon1573
Copy link
Contributor

Dragon1573 commented Dec 25, 2024

I should do a PR for each package, right?

I think you may need to create pull requests for each versions of these packages.

"Sparse checkout" feature is enabled on my local clone. Sparse checkout the directory /manifests/m/Microsoft/DotNet with --no-cone mode and try following command. You'll have to create such that LARGE amount of pull requests ...

22:06:14 D:\...\winget-pkgs  [master ≡] 1ms pwsh> C:\Applications\Git\Git\usr\bin\find.exe ./manifests/m/Microsoft/DotNet -type f -name '*installer.yaml' | C:\Applications\Git\Git\usr\bin\wc.exe -l
585

Note

It's easy using IDEs or editors to perform a string replacement and submitting them via a single PR. But it's hard (wasting time accurately) creating 585 for each of them. 😞

@flo7000
Copy link

flo7000 commented Dec 25, 2024

okay, i understand, thank you!

so i can be sure that all the paths exist at the new domain? not that i'd have to test that too :D

@Dragon1573
Copy link
Contributor

So I can be sure that all the paths exist at the new domain? not that I'd have to test that too :D

Neither can't I. I've just tested one URL and it's valid. There might need a script for automatically checking these URLs.

@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help-Wanted This is a good candidate work item from the community. Package-Update This package needs to be updated
Projects
None yet
Development

No branches or pull requests

4 participants