Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature]: Missing Fields Notification #124465

Closed
denelon opened this issue Nov 1, 2023 · 2 comments
Closed

[New Feature]: Missing Fields Notification #124465

denelon opened this issue Nov 1, 2023 · 2 comments
Assignees
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Milestone

Comments

@denelon
Copy link
Contributor

denelon commented Nov 1, 2023

Description of the new feature/enhancement

Sometimes a new version of a package is submitted, and the manifest isn't as rich or complete as the "latest" version of that package. I'd like to have a label added to those PRs like "Manifest-Metadata-Consistency".

In addition, I would like an informational message indicating which fields are present in the latest version of the manifest and not in the current PR.

This is not a blocking behavior, but an informational one. This would make it easier for moderators to validate the quality of the current PR. Sometimes the new PR is exactly what is needed, and other times, the missing fields add value.

Proposed technical implementation details (optional)

No response

@denelon denelon added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 1, 2023
@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label Nov 1, 2023
@denelon denelon removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Nov 1, 2023
@mdanish-kh
Copy link
Contributor

[Policy] Area-Validation-Pipeline

@microsoft-github-policy-service microsoft-github-policy-service bot added the Area-Validation-Pipeline Issues related to the manifest validation pipeline. label Nov 1, 2023
@stephengillie
Copy link
Collaborator

I've just built the means to check for missing fields into my PR Watcher. Currently it only checks for AppsAndFeaturesEntries, but other fields could be added.

  • It gathers the version number from WinGet, then uses this to build the installer yaml URL.
  • It downloads this then checks it for the field.
  • Then it checks the current manifest for the field.
  • If the two answers don't match, it alerts.

Should this be increased to check all manifest fields, or only specific ones?
Also, should we move this from the approval step of the process and into the validation step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

No branches or pull requests

4 participants