Use NestedInstallerFiles for generating installer nodes in New Command #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Newcommand fails with error: System.ArgumentNullException: Value cannot be null. (Parameter 'source') #435. This is also one of the regressions from an earlier PR Get new RelativeFilePaths if previous do not exist #415 (sorry 😢). New command for zip installers got broken since PackageParser now uses NestedInstallerFiles to generate installer nodeswinget-create/src/WingetCreateCore/Common/PackageParser.cs
Line 500 in 44a102a
New command needs to be updated to populate the installerMetadata with NestedInstallerFiles now instead of RelativeFilePaths
Manifests to test with
wingetcreate new "https://download.sysinternals.com/files/ZoomIt.zip"wingetcreate new "https://github.com/istio/istio/releases/download/1.17.3/istioctl-1.17.3-win.zip"wingetcreate new "https://github.com/junegunn/fzf/releases/download/0.39.0/fzf-0.39.0-windows_amd64.zip"wingetcreate new "https://github.com/sharkdp/fd/releases/download/v8.7.0/fd-v8.7.0-i686-pc-windows-msvc.zip"Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-create/pull/434&drop=dogfoodAlpha