Add ARM machine types #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
|
/azp run |
|
No commit pushedDate could be found for PR 407 in repo microsoft/winget-create |
|
@ryfu-msft Similar issue we're having over at winget-pkgs with the pipelines. I found re-running the command helps but sometimes it takes 3-4 retries |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: https://learn.microsoft.com/en-us/windows/win32/debug/pe-format#machine-types
In cases where we don't get the architecture from URL, winget-create parses the portable exe for the architecture. Need to add these extra values so that we can correctly parse out ARM packages.
Microsoft Reviewers: codeflow:open?pullrequest=https://github.com/microsoft/winget-create/pull/407&drop=dogfoodAlpha