-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Keeps reporting Google Chrome Needs Updating #696
Comments
This most likely has something to do with Google Chrome's version being "latest" and not the actual version number. Since winget list reports a real version number, it doesn't have a way to determine whether that version is latest or not. Maybe instead of latest, whoever updates the manifest should put the real version number and just remove the previous manifest (this is usually wingetbot these days, so I don't know if it can do that by itself or not). Edit: It already does this for Heroku (see microsoft/winget-pkgs#6003), so it could do the same for Chrome. |
We're looking into whether or not we can auto-detect the version from the MSI installer. If we can, we'll see about updating the version. The automation we have will continue to update the manifest as the version changes if that's the case. |
The MSI reported version 68.46.141, but when I installed it I got version 87.0.4280.141 from list. |
It appears that the installer version doesn't report what is actually being installed. In this case, the MSI version is below the version that is being reported by Add/Remove programs. This would mean that once you had installed the package, you would not be informed about a newer version being available. I'm expecting that other packages will exhibit the same behavior. The question is whether or not the developer/publisher would be willing to update their installer version or we need another mechanism to correctly capture the version of what is being installed in the manifest somehow. |
Can you post the output of |
Yep @jedieaston |
I mean, as we cannot select installer type (exe or msi) now, is it ok to write both types of installers into one manifest? |
@lychichem I'd assume yes as MS Teams uses both |
It can, but note that @wingetbot will remove the exe from the manifest when the hash changes. It should do this without removing the entire manifest, but it's something to be aware of. @ItzLevvie, I don't know if we can figure this out or not until we have a couple versions in the repo, but Edge's exe (and the MSI, if I'm not mistaken) are used to bootstrap an appx package. Can the exe installer still upgrade this? I know I get errors when attempting to do |
If it can, then we don't need to split 7zip into 7zip.exe and 7zip.msi... If you know some switch we don't know, plz share it, thanks! |
I can confirm that the winget binary didn't upgrade my winget installed Google Chrome version. Very strange and annoying behavior, since the whole point of winget is to not go to external websites and deal with installers ... |
@mrcsdf - Are you still seeing this issue? |
$ winget upgrade --all
# Google Chrome Google.Chrome 123.0.6312.86 123.0.6312.87 winget But Chrome says it's already at the latest version: Version 123.0.6312.86. |
Brief description of your issue
Each time I run upgrade only one package comes up as needing an update Google Chrome
Steps to reproduce
winget upgrade # List all packages needing upgrade
Name Id Version Available Source
Google Chrome Google.Chrome 87.0.4280.141 latest winget
winget upgrade Google.Chrome
Found Google Chrome [Google.Chrome]
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://dl.google.com/edgedl/chrome/install/GoogleChromeStandaloneEnterprise64.msi
██████████████████████████████ 68.9 MB / 68.9 MB
Successfully verified installer hash
Starting package install...
Successfully installed
winget upgrade
Name Id Version Available Source
Google Chrome Google.Chrome 87.0.4280.141 latest winget
Expected behavior
Upgrade Chrome does not come up in list of upgradeable apps. I also suspect other apps need upgrade just not coming up as part of the report.
Actual behavior
Google Chrome upgrades and still shows up
Chrome upgrades and then shows up available for upgrade subsequently
Environment
❯ winget --info
Windows Package Manager v0.2.3162 Preview
Copyright (c) Microsoft Corporation. All rights reserved.
Windows: Windows.Desktop v10.0.21286.1000
Package: Microsoft.DesktopAppInstaller v1.11.3162.0
Logs: %LOCALAPPDATA%\Packages\Microsoft.DesktopAppInstaller_8wekyb3d8bbwe\LocalState\DiagOutputDir
Links
Privacy Statement https://aka.ms/winget-privacy
License Agreement https://aka.ms/winget-license
Third Party Notices https://aka.ms/winget-3rdPartyNotice
Any other software?
The text was updated successfully, but these errors were encountered: