Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agreements should not terminate entire context #4351

Open
Trenly opened this issue Apr 5, 2024 · 4 comments
Open

Agreements should not terminate entire context #4351

Trenly opened this issue Apr 5, 2024 · 4 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@Trenly
Copy link
Contributor

Trenly commented Apr 5, 2024

Description of the new feature / enhancement

I'm trying to do an update via winget on a notebook, but it keeps giving this warning "Package contracts were not agreed. Operation cancelled." and I can't find anything about it on the internet...

CLI Output

Originally posted by @Novogumiguel in #4350

When agreements for a single package are present, --accept-package-agreements has not been specified, and WinGet is running in a non-interactive context, the entire flow is terminated. This leads to a negative user experience. Instead, only the single package which requires agreements should fail and upgrades or installs for the remaining packages should be attempted.

Proposed technical implementation details

No response

@Trenly Trenly added the Issue-Feature This is a feature request for the Windows Package Manager client. label Apr 5, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

Hi I'm an AI powered bot that finds similar issues based off the issue title.

Please view the issues below to see if they solve your problem, and if the issue describes your problem please consider closing this one and thumbs upping the other issue to help us prioritize it. Thank you!

Open similar issues:

Closed similar issues:

Note: You can give me feedback by thumbs upping or thumbs downing this comment.

@Trenly
Copy link
Contributor Author

Trenly commented Apr 5, 2024

@stephengillie - Any reason you closed #4301 as resolved? I see the SimilarIssues bot accurately identified this as being the same issue

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Apr 5, 2024
@Novogumiguel
Copy link

I hadn't closed it... the bot did it alone... but about winget it's ok, it worked...

I'm going to open another topic talking about Windows Home Single

@stephengillie
Copy link

@stephengillie - Any reason you closed #4301 as resolved? I see the SimilarIssues bot accurately identified this as being the same issue

I misunderstood #4233 to also be the same issue. Reviewing now, I see that's for dependencies while this is for main packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

3 participants