Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative Dependencies #3007

Open
Trenly opened this issue Feb 23, 2023 · 6 comments
Open

Negative Dependencies #3007

Trenly opened this issue Feb 23, 2023 · 6 comments
Labels
Area-Manifest This may require a change to the manifest Dependencies Related to package level dependencies Issue-Feature This is a feature request for the Windows Package Manager client.

Comments

@Trenly
Copy link
Contributor

Trenly commented Feb 23, 2023

Description of the new feature / enhancement

Sometimes packages require things to not be installed / enabled. The current dependencies flow only accounts for enabling / installing, but doesn't have a way to cleanly terminate the install if windows features need to be disabled or other packages need to be uninstalled.

Currently, installers will just terminate with their error code, which could leave users wondering what the true issue is.

Proposed technical implementation details

No response

@Trenly Trenly added the Issue-Feature This is a feature request for the Windows Package Manager client. label Feb 23, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Feb 23, 2023
@stephengillie
Copy link

Is there an example of a package that prevents another package from being installed?

@stephengillie stephengillie removed the Needs-Triage Issue need to be triaged label Feb 24, 2023
@Trenly
Copy link
Contributor Author

Trenly commented Feb 24, 2023

Is there an example of a package that prevents another package from being installed?

I know that WindowsFeatures does, with some apps like BlueStacks requiring Hyper-V to be disabled (or at least they used to, not sure if it still does).

For packages, one clear example is Corsair.iCUE.3 which requires Corsair.iCUE.4 to not be installed. This is because although they are the "same" application, they are valid for different sets of corsair connected devices. iCUE 3 will throw error 1603, requiring users to go into the logs to find the true error

@Trenly
Copy link
Contributor Author

Trenly commented Feb 24, 2023

@stephengillie - can you tag this with Dependencies too?

@stephengillie stephengillie added the Dependencies Related to package level dependencies label Feb 24, 2023
@R-Adrian
Copy link

Is there an example of a package that prevents another package from being installed?

here's one package that fails to install for me:
microsoft/winget-pkgs#97440

i think that's a bug in the Logitech GHUB installer but it's a very annoying one - it fails to install if newer versions of Microsoft Visual C++ 2015-2019 Redistributable (x64 / x86) are installed and it cannot force-downgrade them.

@Masamune3210
Copy link

It is indeed a bug with G Hub's installer. It tries to install the redists without checking if the dependencies are already satisfied, and takes any error code other than success as failure, promptly aborting the installation shortly after. Unfortunately, the only one that can fix it is Logitech

@Trenly
Copy link
Contributor Author

Trenly commented Jun 16, 2023

[Policy] Area-Manifest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Manifest This may require a change to the manifest Dependencies Related to package level dependencies Issue-Feature This is a feature request for the Windows Package Manager client.
Projects
None yet
Development

No branches or pull requests

4 participants