winget source update returns success (0) when it fails

[o-l-a-v]

Brief description of your issue

The CDN being (at least partially) broken (#2666) seems like an unhandled exception in winget-cli, as it returns success / %errorlevel 0, no?

Following running in CMD as admin should not return success IMO.

C:\Windows\system32>winget source reset --force && winget source update && echo %errorlevel%
Resetting all sources...Done
Updating all sources...
Updating source: msstore...
Done
Updating source: winget...
Cancelled
0

C:\Windows\system32>

Steps to reproduce

Change DNS to replicate CDN being down?

Expected behavior

If sources can't in fact be updated, it should return an error.

Actual behavior

Says updating sources failed, but exit code 0 = success.

Environment

Windows Package Manager v1.3.2691
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.2130
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.18.2691.0

[JohnMcPMS]

This code is assuming that update never fails, and that any "failure" must surely be the user cancelling the update. Whoever wrote that is still using some sort of default user icon with blocky purple... you know what, doesn't matter who wrote it.

winget-cli/src/AppInstallerCLICore/Workflows/SourceFlow.cpp

Lines 201 to 204 in 34e8cbd

	if (!context.Reporter.ExecuteWithProgress(updateFunction).empty())
	{
	context.Reporter.Info() << Resource::String::Cancelled << std::endl;
	}

We can at least return E_ABORT if we think it was cancelled. The real fix would be to actually return the error out of the update attempt so that we can decide between cancellation and error states, even if we always return some generic error like SOURCE_UPDATE_FAILED.