From 33bae585b42a6707e1e2a4348d080e1a96a551b4 Mon Sep 17 00:00:00 2001 From: JohnMcPMS Date: Wed, 4 Sep 2024 14:47:46 -0700 Subject: [PATCH] PS Gallery tests are unreliable (#4791) ## Change These tests that rely on the PowerShell Gallery are unreliable. Disable them. --- src/AppInstallerCLIE2ETests/ConfigureCommand.cs | 1 + src/AppInstallerCLIE2ETests/ConfigureShowCommand.cs | 1 + .../tests/Microsoft.WinGet.Configuration.Tests.ps1 | 8 ++++++-- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/AppInstallerCLIE2ETests/ConfigureCommand.cs b/src/AppInstallerCLIE2ETests/ConfigureCommand.cs index 54b3ab080c..9818498b4e 100644 --- a/src/AppInstallerCLIE2ETests/ConfigureCommand.cs +++ b/src/AppInstallerCLIE2ETests/ConfigureCommand.cs @@ -40,6 +40,7 @@ public void OneTimeTeardown() /// Intentionally has no settings to force a failure, but only after acquiring the module. /// [Test] + [Ignore("PS Gallery tests are unreliable.")] public void ConfigureFromGallery() { TestCommon.EnsureModuleState(Constants.GalleryTestModuleName, present: false); diff --git a/src/AppInstallerCLIE2ETests/ConfigureShowCommand.cs b/src/AppInstallerCLIE2ETests/ConfigureShowCommand.cs index 9ed09d2b76..6896300b6a 100644 --- a/src/AppInstallerCLIE2ETests/ConfigureShowCommand.cs +++ b/src/AppInstallerCLIE2ETests/ConfigureShowCommand.cs @@ -29,6 +29,7 @@ public void OneTimeTearDown() /// Simple test to confirm that a resource without a module specified can be discovered in the PSGallery. /// [Test] + [Ignore("PS Gallery tests are unreliable.")] public void ShowDetailsFromGallery() { TestCommon.EnsureModuleState(Constants.GalleryTestModuleName, present: false); diff --git a/src/PowerShell/tests/Microsoft.WinGet.Configuration.Tests.ps1 b/src/PowerShell/tests/Microsoft.WinGet.Configuration.Tests.ps1 index 49a25e0a9f..e58815af4f 100644 --- a/src/PowerShell/tests/Microsoft.WinGet.Configuration.Tests.ps1 +++ b/src/PowerShell/tests/Microsoft.WinGet.Configuration.Tests.ps1 @@ -351,7 +351,8 @@ Describe 'Invoke-WinGetConfiguration' { BeforeEach { DeleteConfigTxtFiles } - + +<# PS Gallery tests are unreliable. It 'From Gallery' { EnsureModuleState "XmlContentDsc" $false @@ -366,6 +367,7 @@ Describe 'Invoke-WinGetConfiguration' { $result.UnitResults[0].State | Should -Be "Completed" $result.UnitResults[0].ResultCode | Should -Be -1978285819 } +#> It 'From TestRepo' { EnsureModuleState $e2eTestModule $false @@ -530,7 +532,8 @@ Describe 'Start|Complete-WinGetConfiguration' { BeforeEach { DeleteConfigTxtFiles } - + +<# PS Gallery tests are unreliable. It 'From Gallery' { EnsureModuleState "XmlContentDsc" $false @@ -548,6 +551,7 @@ Describe 'Start|Complete-WinGetConfiguration' { $result.UnitResults[0].State | Should -Be "Completed" $result.UnitResults[0].ResultCode | Should -Be -1978285819 } +#> It 'From TestRepo' { $testFile = GetConfigTestDataFile "Configure_TestRepo.yml"