From 8371d2d4b72606b47ba86c124a6853eef510a4a6 Mon Sep 17 00:00:00 2001 From: Ruben Guerrero Samaniego Date: Tue, 13 Aug 2024 15:10:20 -0700 Subject: [PATCH 1/5] Update nugets --- .../WinGet.RestSource.AppConfig.csproj | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/WinGet.RestSource.AppConfig/WinGet.RestSource.AppConfig.csproj b/src/WinGet.RestSource.AppConfig/WinGet.RestSource.AppConfig.csproj index f03cb729..ad7520d7 100644 --- a/src/WinGet.RestSource.AppConfig/WinGet.RestSource.AppConfig.csproj +++ b/src/WinGet.RestSource.AppConfig/WinGet.RestSource.AppConfig.csproj @@ -14,7 +14,7 @@ true - 1701;1702;NU1701 @@ -42,13 +42,12 @@ - - - - - - + + + + + From 5d004919414ae0e34cf3f676872f2d52e1b9b521 Mon Sep 17 00:00:00 2001 From: Ruben Guerrero Samaniego Date: Tue, 13 Aug 2024 15:28:28 -0700 Subject: [PATCH 2/5] More upgrades --- src/WinGet.RestSource.Functions/SourceFunctions.cs | 8 +------- src/WinGet.RestSource.Functions/Startup.cs | 7 +++++-- .../WinGet.RestSource.Functions.csproj | 4 ++-- .../Tests/AzFunctions/SourceFunctionsTests.cs | 4 ++-- src/WinGet.RestSource/WinGet.RestSource.csproj | 3 ++- 5 files changed, 12 insertions(+), 14 deletions(-) diff --git a/src/WinGet.RestSource.Functions/SourceFunctions.cs b/src/WinGet.RestSource.Functions/SourceFunctions.cs index 99cb80aa..ae93772e 100644 --- a/src/WinGet.RestSource.Functions/SourceFunctions.cs +++ b/src/WinGet.RestSource.Functions/SourceFunctions.cs @@ -1,4 +1,4 @@ -// ----------------------------------------------------------------------- +// ----------------------------------------------------------------------- // // Copyright (c) Microsoft Corporation. Licensed under the MIT License. // @@ -311,8 +311,6 @@ internal async Task SourceOrchestratorHelperAsync SourceOrchestratorHelperAsync SourceOrchestratorHelperAsync /// Azure function startup class. @@ -66,12 +67,14 @@ private static void InjectTelemetryConfiguration(IFunctionsHostBuilder builder) builder.Services.AddSingleton(sp => { var key = AzureFunctionEnvironment.AppInsightsInstrumentationKey; + var telemetryConfiguration = new TelemetryConfiguration(); + if (!string.IsNullOrWhiteSpace(key)) { - return new TelemetryConfiguration(key); + telemetryConfiguration.ConnectionString = key; } - return new TelemetryConfiguration(); + return telemetryConfiguration; }); } } diff --git a/src/WinGet.RestSource.Functions/WinGet.RestSource.Functions.csproj b/src/WinGet.RestSource.Functions/WinGet.RestSource.Functions.csproj index d712dd7a..51f54dbb 100644 --- a/src/WinGet.RestSource.Functions/WinGet.RestSource.Functions.csproj +++ b/src/WinGet.RestSource.Functions/WinGet.RestSource.Functions.csproj @@ -13,7 +13,7 @@ true - 1701;1702;NU1701 @@ -46,7 +46,7 @@ - + diff --git a/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs b/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs index d4519e2e..35673883 100644 --- a/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs +++ b/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs @@ -1,4 +1,4 @@ -// ----------------------------------------------------------------------- +// ----------------------------------------------------------------------- // // Copyright (c) Microsoft Corporation. Licensed under the MIT License. // @@ -51,7 +51,7 @@ public SourceFunctionsTests(ITestOutputHelper log) this.telemetryConfiguration = new TelemetryConfiguration { TelemetryChannel = this.mockTelemetryChannel.Object, - InstrumentationKey = Guid.NewGuid().ToString(), + ConnectionString = Guid.NewGuid().ToString(), }; this.mockHttpClientFactory.Setup( diff --git a/src/WinGet.RestSource/WinGet.RestSource.csproj b/src/WinGet.RestSource/WinGet.RestSource.csproj index 9c4cc61c..1448d347 100644 --- a/src/WinGet.RestSource/WinGet.RestSource.csproj +++ b/src/WinGet.RestSource/WinGet.RestSource.csproj @@ -46,7 +46,7 @@ - + @@ -56,6 +56,7 @@ + From dbd8bd6500be43855a203b8c84aabfeff3e32445 Mon Sep 17 00:00:00 2001 From: Ruben Guerrero Samaniego Date: Tue, 13 Aug 2024 15:43:50 -0700 Subject: [PATCH 3/5] Correct connection string --- .../Tests/AzFunctions/SourceFunctionsTests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs b/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs index 35673883..a03f461e 100644 --- a/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs +++ b/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs @@ -51,7 +51,7 @@ public SourceFunctionsTests(ITestOutputHelper log) this.telemetryConfiguration = new TelemetryConfiguration { TelemetryChannel = this.mockTelemetryChannel.Object, - ConnectionString = Guid.NewGuid().ToString(), + ConnectionString = "key1=value1", }; this.mockHttpClientFactory.Setup( From f4ab5ea8b910c169ae1acfc5f04e5cb7c18329a2 Mon Sep 17 00:00:00 2001 From: Ruben Guerrero Samaniego Date: Tue, 13 Aug 2024 15:44:03 -0700 Subject: [PATCH 4/5] Correct connection string2 --- src/WinGet.RestSource.Functions/Startup.cs | 2 +- .../Tests/AzFunctions/SourceFunctionsTests.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/WinGet.RestSource.Functions/Startup.cs b/src/WinGet.RestSource.Functions/Startup.cs index d225815c..bdd33544 100644 --- a/src/WinGet.RestSource.Functions/Startup.cs +++ b/src/WinGet.RestSource.Functions/Startup.cs @@ -71,7 +71,7 @@ private static void InjectTelemetryConfiguration(IFunctionsHostBuilder builder) if (!string.IsNullOrWhiteSpace(key)) { - telemetryConfiguration.ConnectionString = key; + telemetryConfiguration.ConnectionString = $"InstrumentationKey={key}"; } return telemetryConfiguration; diff --git a/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs b/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs index a03f461e..40e15093 100644 --- a/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs +++ b/src/WinGet.RestSource.UnitTest/Tests/AzFunctions/SourceFunctionsTests.cs @@ -51,7 +51,7 @@ public SourceFunctionsTests(ITestOutputHelper log) this.telemetryConfiguration = new TelemetryConfiguration { TelemetryChannel = this.mockTelemetryChannel.Object, - ConnectionString = "key1=value1", + ConnectionString = $"InstrumentationKey={Guid.NewGuid()}", }; this.mockHttpClientFactory.Setup( From 4a1b11d41623f55ef32a83cac0169b180a3ab13e Mon Sep 17 00:00:00 2001 From: Ruben Guerrero Samaniego Date: Wed, 14 Aug 2024 11:19:35 -0700 Subject: [PATCH 5/5] Two more --- .../WinGet.RestSource.AppConfig.csproj | 1 + src/WinGet.RestSource/WinGet.RestSource.csproj | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/WinGet.RestSource.AppConfig/WinGet.RestSource.AppConfig.csproj b/src/WinGet.RestSource.AppConfig/WinGet.RestSource.AppConfig.csproj index ad7520d7..d50639c9 100644 --- a/src/WinGet.RestSource.AppConfig/WinGet.RestSource.AppConfig.csproj +++ b/src/WinGet.RestSource.AppConfig/WinGet.RestSource.AppConfig.csproj @@ -56,6 +56,7 @@ + diff --git a/src/WinGet.RestSource/WinGet.RestSource.csproj b/src/WinGet.RestSource/WinGet.RestSource.csproj index 1448d347..c4622315 100644 --- a/src/WinGet.RestSource/WinGet.RestSource.csproj +++ b/src/WinGet.RestSource/WinGet.RestSource.csproj @@ -56,7 +56,7 @@ - +