Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotifyUnicastIpAddressChange no longer accepts a bool as its fourth parameter #2632

Closed
Hawk777 opened this issue Aug 28, 2023 · 1 comment · Fixed by #2635
Closed

NotifyUnicastIpAddressChange no longer accepts a bool as its fourth parameter #2632

Hawk777 opened this issue Aug 28, 2023 · 1 comment · Fixed by #2635
Labels
bug Something isn't working

Comments

@Hawk777
Copy link

Hawk777 commented Aug 28, 2023

Summary

In older versions of the windows crate, it was possible to pass a bool as the fourth parameter to NotifyUnicastIpAddressChange. However in the current version (and perhaps a few recent older versions as well), this now fails with “trait bound bool: CanInto<BOOLEAN> is not satisfied”.

Crate manifest

No response

Crate code

No response
@Hawk777 Hawk777 added the bug Something isn't working label Aug 28, 2023
@kennykerr kennykerr added bug Something isn't working and removed bug Something isn't working labels Aug 28, 2023
@kennykerr
Copy link
Collaborator

I suspect the metadata that is used to produce the bindings changed since older versions so that the parameter, previously incorrectly defined as BOOL, is now BOOLEAN for which we don't have the conversion support. Either way, that's an easy fix.

@kennykerr kennykerr mentioned this issue Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix BOOLEAN parameter binding microsoft/windows-rs
2 participants
@Hawk777 @kennykerr