Release request for windows-rs 0.49.0 for WDK additions.

[chyyran]

Requesting a new release of windows-rs for WDK additions, particularly ntifs.h headers in Wdk_Storage_FileSystem.

[kennykerr]

Which crate are you using?

[chyyran]

I’m using windows

[kennykerr]

Thanks, have you tested against github? Happy to release an update if you've validated that the APIs you need work as expected.

[chyyran]

Tested against GitHub and it seems to be working fine with one caveat. WDK functions convert their NTSTATUS errors to HRESULT so they can return Result<T, windows::core::Error>. My particular use case requires the base NTSTATUS in case of errors. Could WDK functions be made to return Result<T, NTSTATUS> or a wrapped version such that the original NTSTATUS is recoverable where relevant? (Should I file a new issue for this?)

For now my current workaround is to use functions from windows-sys but wrap the return values in windows::Win32::Foundation::NTSTATUS but this doesn't feel like a great workaround.

[tim-weis]

@chyyran NTSTATUS values can be losslessly represented as HRESULT values. To recover the corresponding NTSTATUS value from a windows::core::Error you would call code() to get the HRESULT value, and then unset bit 4 (N).

[chyyran]

Thanks @tim-weis, in which case everything works as expected.

[riverar]

Heads up, the documentation linked above numbers the most significant bit as bit 0. Bit 4 in this case is really bit 28.

[kennykerr]

Thanks for testing. Will publish #2605 today.