Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: expose IID COM constant and more in windows-sys #2366

Closed
poliorcetics opened this issue Mar 7, 2023 · 6 comments
Closed
Labels
enhancement New feature or request

Comments

@poliorcetics
Copy link
Contributor

poliorcetics commented Mar 7, 2023

Motivation

I'm working to update the sysinfo to windows-sys instead of winapi and I'm missing some things:

Missing elements

  • IID (specifically for the windows::Win32::System::Wmi::IWbemLocator) is not in windows-sys but is in windows
  • ULARGE_INTEGER

Drawbacks

No response

Rationale and alternatives

No response

Additional context

I remember something about the COM APIs not being in windows-sys voluntarily ?

@poliorcetics poliorcetics added the enhancement New feature or request label Mar 7, 2023
@poliorcetics
Copy link
Contributor Author

I'm going to update the top comment with missing elements as I find them

@kennykerr
Copy link
Collaborator

@poliorcetics
Copy link
Contributor Author

So necessarily using windows, I don't think that'll go well for compile times sadly (I understand you can't do much about this)

@GuillaumeGomez, before I go any further, would you accept an MR going from winapi to windows ?

@GuillaumeGomez
Copy link
Contributor

If it provides the same functionalities with no downgrade in performance or compilation time, all good for me.

@kennykerr
Copy link
Collaborator

Do give it a try. I am regularly findings ways to improve windows crate build time. Most recently #2360.

@poliorcetics
Copy link
Contributor Author

Thanks to you both, will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants