DWORD * is replaced with enum (not pointer)

[krzysdz]

In the 10.0.19041.5-preview.39 NuGet the DWORD * CryptQueryObject parameters (pdwContentType and pdwFormatType) have CERT_QUERY_FLAGS and CERT_QUERY_FORMAT_TYPE types respectively.

The same issue applies to CryptAcquireCertificatePrivateKey (pdwKeySpec). I didn't find any more cases - most DWORD * parameters I found in the Windows SDK header files are just uint * in the .winmd.

The original declaration:

WINCRYPT32API
BOOL
WINAPI
CryptQueryObject(
    _In_ DWORD                    dwObjectType,
    _In_ const void               *pvObject,
    _In_ DWORD                    dwExpectedContentTypeFlags,
    _In_ DWORD                    dwExpectedFormatTypeFlags,
    _In_ DWORD                    dwFlags,
    _Out_opt_ DWORD               *pdwMsgAndCertEncodingType,
    _Out_opt_ DWORD               *pdwContentType,
    _Out_opt_ DWORD               *pdwFormatType,
    _Out_opt_ HCERTSTORE          *phCertStore,
    _Out_opt_ HCRYPTMSG           *phMsg,
    _Outptr_opt_result_maybenull_ const void **ppvContext
    );

Declaration in the .winmd (formatted):

[DllImport("CRYPT32", ExactSpelling = true, SetLastError = true)]
public unsafe static extern BOOL CryptQueryObject(
	[In] CryptQueryObject_dwObjectTypeFlags dwObjectType, // This enum does not contain flags (and has no
	                                                      // [Flags] attribute), but has "Flags" in name
	[In][Const] void* pvObject,
	[In] CERT_QUERY_FLAGS dwExpectedContentTypeFlags, // Contains invalid "flags", it should contain only
	                                                  // the CERT_QUERY_CONTENT_FLAG_* ones
	[In] CERT_QUERY_FORMAT_FLAGS dwExpectedFormatTypeFlags,
	[In] uint dwFlags,
	[Optional][Out] CertOpenStore_dwEncodingType pdwMsgAndCertEncodingType,
	[Optional][Out] CERT_QUERY_FLAGS pdwContentType,      // It should be a pointer, not a value. The enum
	                                                      // contains too many values and should not be marked
							      // with the [Flags] attribute. This enum should
							      // contain only /CERT_QUERY_CONTENT_(?!FLAG_)\w+/
							      // values.
	[Optional][Out] CERT_QUERY_FORMAT_TYPE pdwFormatType, // It should be a pointer, not a value
	[Optional][Out] void** phCertStore,
	[Optional][Out] void** phMsg,
	[Optional][Out][Const] void** ppvContext);

[krzysdz]

This problem can also affect other pointer type parameters such as LPDWORD.
The InternetGetConnectedStateExA/W functions have _Out_opt_ LPDWORD lpdwFlags as the first parameter, but in the metadata the pointer is lost:

[mikebattista]

Thanks for filing. We recently added some automation to improve our enum coverage, and this looks like a bug with that not preserving pointers.