-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Few little errors #1961
Comments
Moving forward, please file one issue per request. Thanks! |
There are A and W versions of this type, so skipping this one. |
Those structs are already aligned well for x86, x64, and arm64. If you suspect packing/alignment issues on other structures, please run them through MSVC |
Closing per #1979 (comment). |
1 - windows.win32.networkmanagement.rras
PMPRADMINCONNECTIONHANGUPNOTIFICATION3
Last parameter is missing a pointer, see https://learn.microsoft.com/en-us/windows/win32/api/mprapi/nf-mprapi-mpradminconnectionhangupnotification3
The SDK is also missing the pointer in mprapi.h,. That struct is relatively big so I doubt it's meant to be passed by value, especically as it's a pointer in all the other function pointers that use RAS_CONNECTION_3 and has members tagged as OUT in mprapi.
2 - Links for all the AVI- prefixed types in Windows.Win32.Media.DirectShow are 404
For instance:
AVIStreamHeader
https://learn.microsoft.com/windows/win32/api/avifmt/ns-avifmt-avistreamheader
This is now here - https://learn.microsoft.com/en-us/previous-versions/windows/desktop/api/avifmt/ns-avifmt-avistreamheader
AVISUPERINDEX
https://learn.microsoft.com/windows/win32/api/aviriff/ns-aviriff-avisuperindex
This is now here - https://learn.microsoft.com/en-us/previous-versions/windows/desktop/api/aviriff/ns-aviriff-avisuperindex
AVISTREAMHEADER
https://learn.microsoft.com/windows/win32/api/aviriff/ns-aviriff-avistreamheader
Now here - https://learn.microsoft.com/en-us/previous-versions/windows/desktop/api/aviriff/ns-aviriff-avistreamheader
Basically they've all moved into previous-versions purgatory
3- These shouldn't have the StructSizeField attribute, cbSize here is the size of the data pointed to, not the size of the struct
windows.win32.com.structuredstorage - BLOB
windows.win32.storage.structuredstorage - BSTRBLOB
4 - Help links for windows.win32.graphics.gdiplus BitMap and Image are pointing to completely wrong things
Bitmap is here
https://learn.microsoft.com/en-us/windows/win32/api/gdiplusheaders/nl-gdiplusheaders-bitmap
instead of
https://learn.microsoft.com/windows/win32/tablet/bitmap-element
Image is here
https://learn.microsoft.com/en-us/windows/win32/api/gdiplusheaders/nl-gdiplusheaders-image
instead of
https://learn.microsoft.com/windows/win32/windowsribbon/windowsribbon-element-image
5 - windows.win32.networking.winhttp
URL_COMPONENTS has an Ansi attribute, but the strings are wide, and it only exists in wide format
6 - windows.win32.graphics.gdi
Some structs in here are missing packing attributes. Snippets from wingdi.h
TextMetricA/W - 4 byte
RGBTriple - 1 byte
NewTextMetricA/W - 4 bytes
The text was updated successfully, but these errors were encountered: