D3D11_CLEAR_FLAG does not implement bit ops and uses i32 instead of u32 internally

[CarePackage17]

Which crate is this about?

windows

Crate version

0.43.0

Summary

I'm writing a D3D11 sample app with the windows crate and came across a minor inconvenience: D3D11_CLEAR_FLAG does not implement bit ops, like e.g. D3D11_CREATE_DEVICE_FLAG does, so instead of writing

let clear_flags = D3D11_CLEAR_DEPTH | D3D11_CLEAR_STENCIL;

I need to write

let clear_flags = D3D11_CLEAR_DEPTH.0 | D3D11_CLEAR_STENCIL.0;

Later I want to call ID3D11DeviceContext::ClearDepthStencilView, but the underlying type of clear_flags is i32 while the API expects a u32, so I need to add another cast so it compiles again:

let dsv = ...
let context = ...

context.ClearDepthStencilView(&dsv, clear_flags as u32, 1.0, 0);

I think this could be fixed by using u32 as the underlying type for D3D11_CLEAR_FLAG, like D3D11_CREATE_DEVICE_FLAG does.

Toolchain version/configuration

Default host: x86_64-pc-windows-msvc
rustup home: C:\Users\waved.rustup

stable-x86_64-pc-windows-msvc (default)
rustc 1.65.0 (897e37553 2022-11-02)

Reproducible example

No response

Crate manifest

No response

Expected behavior

No response

Actual behavior

No response

Additional comments

No response

[kennykerr]

According to the docs, this should be unsigned and needs the Flags attribute. Will transfer to the win32metadata repo for resolution.

https://learn.microsoft.com/en-us/windows/win32/api/d3d11/ne-d3d11-d3d11_clear_flag

[mikebattista]

Windows.Win32.Graphics.Direct3D11.D3D11_CLEAR_FLAG : => [Flags]
Windows.Win32.Graphics.Direct3D11.D3D11_CLEAR_FLAG.value__...System.Int32 => System.UInt32