New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDropSource::[QueryContinueDrag|GiveFeedback] needs PreserveSig treatment #1291

Closed

littleBugHunter opened this issue Oct 1, 2022 · 1 comment

Assignees

Labels

littleBugHunter commented Oct 1, 2022

IDropSource::[QueryContinueDrag|GiveFeedback] methods can return alternative success codes and appear to meet criteria for PreserveSig.
Currently it is impossible to implement a working IDropSource in rust, as the DragDrop Operation never finishes with DRAGDROP_S_DROP or DRAGDROP_S_CANCEL
See:
https://learn.microsoft.com/en-us/windows/win32/api/oleidl/nf-oleidl-idropsource-querycontinuedrag
https://learn.microsoft.com/en-us/windows/win32/api/oleidl/nf-oleidl-idropsource-givefeedback

littleBugHunter mentioned this issue

Bug: IDropSource needs to return Ok values microsoft/windows-rs#2080

Closed

kennykerr added the rust label

mikebattista self-assigned this

mikebattista added the usability label

Collaborator

mikebattista commented Oct 3, 2022

Windows.Win32.System.Ole.IDropSource.GiveFeedback : => [PreserveSig]
Windows.Win32.System.Ole.IDropSource.QueryContinueDrag : => [PreserveSig]

mikebattista closed this as completed in

f9b9972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment